Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@orderby should throw an error if incorrect column syntax is used #288

Open
metanoid opened this issue Nov 14, 2019 · 1 comment
Open

@orderby should throw an error if incorrect column syntax is used #288

metanoid opened this issue Nov 14, 2019 · 1 comment
Assignees
Labels

Comments

@metanoid
Copy link

Using Query.jl in conjunction with DataFrames.jl I find that I often make silly mistakes with the syntax, such as:

df |>
      @orderby(:IssueDate) |>
      DataFrame

instead of

df |>
      @orderby(_.IssueDate) |>
      DataFrame

In such cases, Query.jl simply ignores the @orderby line, and does so silently.

I think that if the arguments to @orderby do not resolve to something in df that can be ordered, there should be a warning thrown, if not an error.

@davidanthoff davidanthoff self-assigned this Nov 14, 2019
@davidanthoff
Copy link
Member

Agreed! Or, even better, it could just work with @orderby(:IssueDate) as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants