Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failure: undefined: types.Alias/types.Unalias #480

Open
ldez opened this issue Aug 23, 2024 · 1 comment · May be fixed by #481
Open

CI failure: undefined: types.Alias/types.Unalias #480

ldez opened this issue Aug 23, 2024 · 1 comment · May be fixed by #481

Comments

@ldez
Copy link
Contributor

ldez commented Aug 23, 2024 •
edited
Loading

Currently the CI fails because:

#8 13.55 internal/xtypes/xtypes.go:224:14: undefined: types.Alias
#8 13.55 internal/xtypes/xtypes.go:226:30: undefined: types.Unalias

types.Alias and types.Unalias have been introduced in go1.22.

The current min version inside the go.mod is go1.19

go-ruleguard/go.mod

Line 3 in 0fe6f58

go 1.19

The version used inside tests is go1.18

go-ruleguard/_test/install/gitclone/Dockerfile

Line 1 in 0fe6f58

FROM golang:1.18-alpine AS build

go-ruleguard/_test/install/binary_gopath/Dockerfile

Line 1 in 0fe6f58

FROM golang:1.18-alpine AS build

go-ruleguard/_test/install/binary_nogopath/Dockerfile

Line 1 in 0fe6f58

FROM golang:1.18-alpine AS build

go-ruleguard/_test/install/gitclone_nobuildtag/Dockerfile

Line 1 in 0fe6f58

FROM golang:1.18-alpine AS build

go-ruleguard/_test/install/gitclone_toolsgo/Dockerfile

Line 1 in 0fe6f58

FROM golang:1.18-alpine AS build

And the tests use GO111MODULE=off

go-ruleguard/_test/install/gitclone/test.bash

Line 31 in 0fe6f58

export GO111MODULE=off

go-ruleguard/_test/install/binary_nogopath/test.bash

Line 30 in 0fe6f58

export GO111MODULE=off

There are several solutions that need to be discussed to fix the problem:

  • use build tags and split internal/xtypes/xtypes.go
  • update the min version to go1.22 (but it requires to remove/fix GO111MODULE=off tests)
@ldez ldez mentioned this issue Aug 23, 2024
Merged
@quasilyte
Copy link
Owner

Updating the min version sounds like an easier way around the problem.

@ldez ldez linked a pull request Aug 23, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update min Go version ldez/go-ruleguard
2 participants
@ldez @quasilyte