Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using bundles forbids normal rules embedding #355

Open
quasilyte opened this issue Jan 10, 2022 · 1 comment
Open

Using bundles forbids normal rules embedding #355

quasilyte opened this issue Jan 10, 2022 · 1 comment

Comments

@quasilyte
Copy link
Owner

It'll require dsl package dependency at the run time.
quasilyte added a commit to quasilyte/go-perfguard that referenced this issue Jan 10, 2022
@quasilyte
perfguard/_rules: remove bundle
240ab67 
See quasilyte/go-ruleguard#355

perfguard should not need that dependency when custom rules
are not used. This is why we're using rules embedding.
This was referenced Jan 10, 2022
Merged
Closed
@quasilyte
Copy link
Owner Author

Maybe we can avoid custom decls generation for bundles?

	CustomDecls: []string{
		"var Bundle = dsl.Bundle{}",
	},

I'm not sure this part is 100% required for the generated data.
We can add a new field to the ir.File that will represent the parsed bundle data (which is an empty object right now).

quasilyte added a commit to quasilyte/go-perfguard that referenced this issue Jan 10, 2022
@quasilyte
perfguard/_rules: remove bundle (#50)
1dc20ed 
See quasilyte/go-ruleguard#355

perfguard should not need that dependency when custom rules
are not used. This is why we're using rules embedding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@quasilyte