Introduce some gRPC?

[edeandrea]

Should we introduce some gRPC into some of the services? Maybe a matching gRPC layer in the heroes/villains? We're already showing rest in rest-fights & rest-narration, so maybe for east/west traffic between rest-fights and rest-heroes/rest-villains we go to gRPC?

@cescoffier / @agoncal / @holly-cummins what do you all think?

[edeandrea]

Although by using rest in heroes/villains, in rest-fights we're showing how to use the rest client and I'm not sure we'd want to get rid of that.

Maybe in heroes & villains we have both rest & gRPC, then maybe in rest-fights a runtime flag which tells which client to use (rest vs gRPC)?

@holly-cummins This would also bring in the ability to use the Pact gRPC plugin

[agoncal]

What about introducing a new microservice ?

With @cescoffier we once had this idea of having another microservice that would return a "location/universe/planet" where the fight happens. That would return an image (the image of the planet, location....that would be displayed in the UI as a background) and a name/description of the location ("Abafar is a desert planet located in the Outer Rim with a completely white surface..."). We would have a new button that would pick a random location. This way you can pick a random villain, a random hero, and make them fight on a random location.

WDYT ? And having gRPC could be something we could also add to the workshop

[cescoffier]

Another idea I had recently, is to have a variant of the reactive crud service using gRPC instead of the reactive rest approach. The rest of the code stay unchanged.

[edeandrea]

I think we should not have different variants of the different services. I think that is too much of a maintenance headache, especially since we produce & maintain container images. We'd have to maintain variants of the container images too.

I think there is value in showing both blocking & reactive rest endpoints as well as both reactive & blocking rest clients (like we have today). It's also easy to run benchmarks and show performance differences between fully blocking & fully reactive, since both villains & heroes use the same schema with the same amount of data. They are essentially the same service.

[edeandrea]

@agoncal / @cescoffier thinking down the location service rabbit hole a bit, do you have in mind a set of locations & images to pick from? We'd probably need quite a few.

[cescoffier]

No, I don’t have any pictures. I was thinking taking pictures of famous cities and places in the world, plus a few places related to super heroes (Metropolis, Gotham City, …). We do not need a lot. Something like 50 would be enough.

…

On Wed 18 Oct 2023 at 19:10, Eric Deandrea ***@***.***> wrote: @agoncal <https://github.com/agoncal> / @cescoffier <https://github.com/cescoffier> thinking down the location service rabbit hole a bit, do you have in mind a set of locations & images to pick from? We'd probably need quite a few. — Reply to this email directly, view it on GitHub <#379 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADCG7KXG2ET3COGETQSAM3YAAEPNAVCNFSM6AAAAAA54G5WP6VHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM3TGMJYGEZTM> . You are receiving this because you were mentioned.Message ID: <quarkusio/quarkus-super-heroes/repo-discussions/379/comments/7318136@ github.com>

[cescoffier]

I like the idea of introducing gRPC and Kotlin. However, the combination can be slightly weird as we do not support kotlin-grpc. So, kotlin users might be slightly confused.

[edeandrea]

I guess I'm not sure what kotlin-grpc is. Is that some other non-quarkus library?

[cescoffier]

Yes, it’s not supported in Quarkus. It’s the traditional way to use gRPC in Kotlin.

[edeandrea]

Looking at https://grpc.io/docs/languages/kotlin/quickstart/ it doesn't look a whole lot different than what I'm doing...(https://github.com/edeandrea/quarkus-super-heroes/blob/location-service/grpc-locations/src/main/kotlin/io/quarkus/sample/superheroes/location/grpc/LocationGrpcService.kt for the server & https://github.com/edeandrea/quarkus-super-heroes/blob/location-service/grpc-locations/src/test/kotlin/io/quarkus/sample/superheroes/location/grpc/LocationGrpcServiceTests.kt for the client)

[edeandrea]

@cescoffier / @agoncal would you be able to help me get some pictures/descriptions of locations? I've started...

https://github.com/quarkusio/quarkus-super-heroes/blob/characterdata/all-locations.sql & https://github.com/quarkusio/quarkus-super-heroes/tree/characterdata/images/locations

You can either commit directly to the characterdata branch, or do a PR and I can merge.

[edeandrea]

I've created this as an issue now that its underway.