Skip to content

Conversation

@NoureldinYosri
Copy link
Contributor

@NoureldinYosri NoureldinYosri commented Nov 3, 2025

  • adds the magnitude approximation protocol to approximate general unitaries
  • fixes the docstring for the Z-rotation protocols to be $e^{i\theta Z}$ ( $= Rz(-2\theta)$ ) instead of $Rz(2\theta)$

@NoureldinYosri NoureldinYosri marked this pull request as ready for review November 3, 2025 23:10
@NoureldinYosri
Copy link
Contributor Author

@mpharrigan can you take a look at this one as well?

@mpharrigan
Copy link
Collaborator

is it possible to update the convention in a future PR to be exp[-i theta/2 z]

Copy link
Collaborator

@mpharrigan mpharrigan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@NoureldinYosri
Copy link
Contributor Author

is it possible to update the convention in a future PR to be exp[-i theta/2 z]

at the moment it matches the convention from arXiv:2203.10064, personally I don't have a preference to either, so yes it can be changed

@NoureldinYosri NoureldinYosri merged commit 4a0ff59 into quantumlib:main Nov 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants