Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update protobuf API calls so it does not have to be pinned to protobuf-4 #6651

Closed
pavoljuhas opened this issue Jun 25, 2024 · 1 comment · Fixed by #6683
Closed

update protobuf API calls so it does not have to be pinned to protobuf-4 #6651

pavoljuhas opened this issue Jun 25, 2024 · 1 comment · Fixed by #6683
Assignees
@verult @senecameeks
Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

protocolbuffers/protobuf@2699579 removed the including_default_value_fields argument which is used in cirq-google.
This is temporarily fixed by pinning protobuf-4.x in #6650

TODO: update API calls to use the new argument always_print_fields_with_no_presence.

Cirq version

1.5.0.dev at 0aae3c1.
@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label Jun 25, 2024
@NoureldinYosri NoureldinYosri added triage/discuss Needs decision / discussion, bring these up during Cirq Cynque triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Jul 3, 2024
@dstrain115
Copy link
Collaborator

Let's update the relevant calls (or recompile the protos if necessary) to use the new call. Investigate compatibility with internal systems.

Can either @verult @senecameeks take this?

@maffoo maffoo mentioned this issue Jul 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@verult verult

@senecameeks senecameeks

Labels
kind/health For CI/testing/release process/refactoring/technical debt items triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow using protobuf version 5 and later quantumlib/Cirq
5 participants
@verult @pavoljuhas @NoureldinYosri @senecameeks @dstrain115