Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External link returns 404 #6646

Closed
bongiojp opened this issue Jun 13, 2024 · 4 comments · Fixed by #6668
Closed

External link returns 404 #6646

bongiojp opened this issue Jun 13, 2024 · 4 comments · Fixed by #6668
Assignees
@NoureldinYosri
Labels
kind/bug-report Something doesn't seem to work. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add

Comments

@bongiojp
Copy link

The "education page" link is broken on https://quantumai.google/cirq/start/start
@bongiojp bongiojp added the kind/bug-report Something doesn't seem to work. label Jun 13, 2024
@NoureldinYosri NoureldinYosri added the triage/discuss Needs decision / discussion, bring these up during Cirq Cynque label Jul 3, 2024
@dstrain115
Copy link
Collaborator

@aasfaw Do you know what the proper link for the education page should be now?

@dstrain115 dstrain115 added triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add and removed triage/discuss Needs decision / discussion, bring these up during Cirq Cynque labels Jul 3, 2024
@aasfaw
Copy link
Contributor

aasfaw commented Jul 3, 2024

educational resources page: https://quantumai.google/resources
all cirq pages start here: https://quantumai.google/cirq

@pavoljuhas pavoljuhas mentioned this issue Jul 17, 2024
Merged
pavoljuhas added a commit that referenced this issue Jul 18, 2024
@pavoljuhas
Use absolute URL for Cirq education resources (#6668)
8d6c1d2 
Problem: Documentation build converts root-anchored reference /REF
in notebook markdown to https://quantumai.google/cirq/REF
but education page is at https://quantumai.google/resources.

Solution: Use absolute URL to the education page.

Fixes: #6646
@pavoljuhas
Copy link
Collaborator

pavoljuhas commented Jul 18, 2024 •
edited
Loading

@pavoljuhas pavoljuhas reopened this Jul 18, 2024
@pavoljuhas
Copy link
Collaborator

Confirming working "education page" link after nightly docs build. Closing as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NoureldinYosri NoureldinYosri

Labels
kind/bug-report Something doesn't seem to work. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use absolute URL for Cirq education resources pavoljuhas/Cirq
5 participants
@bongiojp @aasfaw @pavoljuhas @NoureldinYosri @dstrain115