Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update produce-package.sh script #6623

Open
pavoljuhas opened this issue May 30, 2024 · 2 comments
Open

Update produce-package.sh script #6623

pavoljuhas opened this issue May 30, 2024 · 2 comments
Assignees
Labels
kind/health For CI/testing/release process/refactoring/technical debt items

Comments

@pavoljuhas
Copy link
Collaborator

Description of the issue

The release script "dev_tools/packaging/produce-package.sh dist" uses setup.py to build wheels resulting in the following warnings

SetuptoolsDeprecationWarning: setup.py install is deprecated.
!!

        ********************************************************************************
        Please avoid running ``setup.py`` directly.
        Instead, use pypa/build, pypa/installer or other
        standards-based tools.

        See https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html for details.
        ********************************************************************************

!!

TODO

Switch to up-to-date wheel builder. Consider making the wheels reproducible and timestamped.

Cirq version

1.4.0.dev at ab86979

@pavoljuhas pavoljuhas added the kind/health For CI/testing/release process/refactoring/technical debt items label May 30, 2024
@pavoljuhas pavoljuhas self-assigned this May 30, 2024
@NoureldinYosri
Copy link
Collaborator

I faced this issue before... using pip install . should work unless the setup.py file has dependencies not in the default environment in which case they will need to added to the pyproject.toml file as

[build-system]
requires = ["setuptools", "wheel", ...etc]

@pavoljuhas
Copy link
Collaborator Author

The issue here is that the packaging script calls setup.py here -

python3 setup.py -q bdist_wheel -d "${out_dir}"

which is a deprecated way of building wheels that needs to be replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/health For CI/testing/release process/refactoring/technical debt items
Projects
None yet
Development

No branches or pull requests

2 participants