Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoiseModelFromGoogleNoiseProperties should raise an error when simulations use qubits not on the device or an uncompiled circuit #6608

Open
NoureldinYosri opened this issue May 20, 2024 · 2 comments
Assignees
Labels
good first issue This issue can be resolved by someone who is not familiar with the codebase. A good starting issue. kind/bug-report Something doesn't seem to work. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add

Comments

@NoureldinYosri
Copy link
Collaborator

Description of the issue
Noisy Simulation describes how to run simulations with realistic noise obtained from a real quantum device. however when using that noise model with a gate that is not native to the device the simulation, no noise gets added (e.g. #6607 (comment)). another issue is that when the circtuit uses qubits not on the device a key error is raised with little information explaining why that is.

Proposed Solution
Before (or while) running the simulation validate that the qubits and gets in the circuit uses supported qubits and gates.

How to reproduce the issue
#6607

Cirq version
1.4.0.dev20240419073809

@NoureldinYosri NoureldinYosri added the kind/bug-report Something doesn't seem to work. label May 20, 2024
@NoureldinYosri NoureldinYosri added good first issue This issue can be resolved by someone who is not familiar with the codebase. A good starting issue. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add labels May 22, 2024
@shef4
Copy link
Contributor

shef4 commented Jun 12, 2024

Hi, I'm interested in taking on this issue. Will look more into the current implementation.

@NoureldinYosri
Copy link
Collaborator Author

@shef4 thanks for offering to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This issue can be resolved by someone who is not familiar with the codebase. A good starting issue. kind/bug-report Something doesn't seem to work. no QC knowledge needed Want to contribute to Cirq, but don't know quantum computing? This issue is for you. triage/accepted there is consensus amongst maintainers that this is a real bug or a reasonable feature to add
Projects
None yet
Development

No branches or pull requests

2 participants