Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make etc/clean.py python 2/3 compatible #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make etc/clean.py python 2/3 compatible #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions etc/clean.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,25 @@
#!/usr/bin/env python
import os


def main():
path = '.'
count = 0
for name, folders, files in os.walk(path):
for name, folders, files in os.walk(path, topdown=False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the topdown arg for here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is used so that *.pyc files would be deleted from __pycache__ before we try to delete these directories using os.rmdir() (thus the dirs are preserved if they unexpected files).

for file in files:
if file.endswith('.pyc') \
or file.endswith('~') \
or file.endswith('.pyo'):
count += 1
os.remove(os.path.join(name, file))
for folder in folders:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to do this in addition to deleting the .pyc files inside these directories?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Python 3 saves .pyc files in __pycache__ dirs.

if folder == '__pycache__':
try:
os.rmdir(os.path.join(name, folder))
except OSError:
pass

print "Deleted %s files" % count
print("Deleted %s files" % count)


if __name__ == "__main__":
Expand Down