Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't send RESUMED email if paused while late #11

Open
jikamens opened this issue Mar 16, 2023 · 0 comments
Open

Doesn't send RESUMED email if paused while late #11

jikamens opened this issue Mar 16, 2023 · 0 comments

Comments

@jikamens
Copy link
Collaborator

If a canary goes late, sends out a LATE email, and then is paused, it never sends out a followup email indicating that it has resumed when it starts reporting again and the pause is automatically cancelled. This leaves someone who is watching the state of the canary via their email notifications thinking that the canary is still late when in fact it's reporting again.

I think removing the late status from a canary when it's paused is probably the right thing to do, so I don't think it should actually send out a RESUMED email in this context; I think it would be more correct to send out a new type of notification specifically for the "paused while late" event which makes it clear that's what happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant