Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xidlehook check might be out of date #24

Open
epchris opened this issue May 23, 2020 · 2 comments · May be fixed by #25
Open

xidlehook check might be out of date #24

epchris opened this issue May 23, 2020 · 2 comments · May be fixed by #25

Comments

@epchris
Copy link

epchris commented May 23, 2020

I have installed xidlehook in arch linux via AUR and it seems as though the comment here:
https://github.com/quantopian/PenguinDome/blob/master/client/plugins/screenlock.py#L125
reflects a perhaps-out-of-date version of xidlehook.

My usage of xidlehook only uses a duration, command and canceller:
--timer <duration> <command> <canceller>
jikamens added a commit that referenced this issue May 24, 2020
@jikamens
Newer xidlehook versions don't have mode argument to --timer
b04cae2 
Support versions of xidlehook which have removed the `mode` argument
to `--timer`, while continuing, at least for the time being, to
also support the older syntax.

Fixes #24.
@jikamens jikamens linked a pull request May 24, 2020 that will close this issue
Open
@jikamens
Copy link
Collaborator

@epchris can you test the branch referenced in the PR above to see if it fixes this for you?
@irlevesque if you are still using the older version of xidlehook which uses the old syntax, can you test to confirm that this change works for you as well?

@irlevesque
Copy link
Member

@jikamens I no longer use xidlehook so I'm sorry I can't test the behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Newer xidlehook versions don't have mode argument to --timer quantopian/PenguinDome
3 participants
@epchris @jikamens @irlevesque