Do not upload a range 1-200 if the representation is only one frame

[BenSouchet]

Currently in the Standalone Publisher if you add a representation of only one frame, 200 frames are published (range from 1-200), it's a bug.

Goal

Fix this incorrect behavior

[BenSouchet]

Currently I fixed an issue with uppercase or mixed case extension, like .PNG that did not match .png so the review was skipped...

But now I will look for the configuration in settings to properly upload image not png review if an image has been set as review.

[BenSouchet]

I also re-enable the Thumbnail integration, that was mistakenly disabled by the Ayon code merge operation.

[BenSouchet]

I added a special case when publishing with the tray Publisher to use the file count instead of the default project anatomy frame range.

The main changes: bec104e

[BenSouchet]

@hfarre Test it when you have time, and if you have specific test cases that can be problematic don 't hesitate

[BenSouchet]

@hfarre following our talk:

Maybe the best should be that in the tracker, asset have values for: frameStart and frameEnd

AND the variant reference has it frameEnd defined to 0, 0 would means no enforced / computed by the pipeline.

This should be the best of all worlds.

[hfarre]

This sounds good, but to be applied, it implies that this will only concider "reference" variant
And maybe, not only reference would need to ignore frame range

But it's only maybe and hypothésis... For the moment we don't have enough vision on those specific case :s

[BenSouchet]

This sounds good, but to be applied, it implies that this will only concider "reference" variant And maybe, not only reference would need to ignore frame range

But it's only maybe and hypothésis... For the moment we don't have enough vision on those specific case :s

It's not an issue every time you want to ignore frame range for a specific task / variant, simply update the correct column / template in the tacker (kitsu) and the value will be properly propagate and then use in the Tray publisher.

[BenSouchet]

Of course if won't be an on/off bool available everywhere but at list you can properly configure the behavior directly on the tracker (for you and the coordos)

[hfarre]

It seems the in subset "render", some additionnal options exist that may be connect to our problematic

Espacially "Collect Original Seq Frame Data"
I'll make more test to dig the way it works

[hfarre]

Test done to publish a single frame throught the traypublisher
Later, another ticket will handle multiple frames in an "image" family, not possible for the moment.
At this moment, the questions on the frame range may come back

But for the moment, it works perfectly fine for a single image !

[BenSouchet]

Test done to publish a single frame throught the traypublisher Later, another ticket will handle multiple frames in an "image" family, not possible for the moment. At this moment, the questions on the frame range may come back

But for the moment, it works perfectly fine for a single image !

Like I said, I think the best way would be to remove this addition I currently added:

if asset_entity["type"] == "asset":
# For asset frameEnd need to be computed based on the file count of each representation
# Setting 0 to specify this need to be computed
collected_data["frameEnd"] = 0
instance.data["frameEnd"] = 0

And add the proper default data directly in the tracker, if you specified 0 for the frameEnd then the length will be computed and not forced.

We could also add the ability to disable the retrieval of the data from the tracker but IMO this isn't a good idea.

[hfarre]

Yes, we'll take care of that later.
Adding a toggle similar to what is done in the subset render option "Collect original sequence frame data" seems like a good solution. When activated, it bypasses the Kitsu data and instead relies on the data/number of files provided to it for publishing.

I'll validate my review on the PR and we'll be able to merge it

[BenSouchet]

Since on kitsu it's not currently possible to override asset custom properties for tasks, the frame range cannot be override for specific tasks...

We will change the special collector for the frame range data and put it optional with ability to disable it (no a big fan to put more power in hand of artists but not other good choice)

[BenSouchet]

I change the method to disable the retrieval of the frame range, now a newly added collector can be disable from the tray publisher settings.

Last thing to add is a condition configurable in the settings to skip task(s), will do it tomorrow

[hfarre]

Nice !

Maybe cast an eye on the render subset, now there's two toogle that seems to do contradictory things:

When toogle, the first allows to get the frame from the given file sequence, and when off, it retrieves the range from kitsu