From 3d1ec9ee94bac4222637bc9791ffc4d051c08fbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tor=20Arne=20Vestb=C3=B8?= Date: Wed, 18 Sep 2024 15:56:10 +0200 Subject: [PATCH] Unblacklist tst_QGraphicsProxyWidget::windowOpacity on macOS Setting the opacity on an NSWindow does not result in a paint event. Pick-to: 6.8 Change-Id: I6d2780191ba97082f7ca80e2aa1094ccf796fb75 Reviewed-by: Volker Hilsheimer --- .../auto/widgets/graphicsview/qgraphicsproxywidget/BLACKLIST | 2 -- .../qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp | 5 +---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/BLACKLIST b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/BLACKLIST index 731b3ae2538..c3cdcf62b1a 100644 --- a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/BLACKLIST +++ b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/BLACKLIST @@ -1,8 +1,6 @@ [scrollUpdate] android b2qt -[windowOpacity] -macos ci [wheelEventPropagation] android [forwardTouchEvent] diff --git a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp index c3f77957f82..74d5fd20062 100644 --- a/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp +++ b/tests/auto/widgets/graphicsview/qgraphicsproxywidget/tst_qgraphicsproxywidget.cpp @@ -2609,11 +2609,8 @@ void tst_QGraphicsProxyWidget::windowOpacity() // and not on the widget or the proxy itself. The entire proxy needs an update // in case it has a window decoration. Update: QGraphicsItem::CacheMode is // disabled on platforms without alpha channel support in QPixmap (e.g., - // X11 without XRender). On macOS, we always get a paint event. + // X11 without XRender). int paints = 0; -#ifdef Q_OS_MACOS - paints = 1; -#endif QTRY_COMPARE(eventSpy.counts[QEvent::UpdateRequest], 0); QTRY_COMPARE(eventSpy.counts[QEvent::Paint], paints);