[FIX] base_tier_validation (#7)

fix-base_tier_validation

Author: kanda999

base_tier_validation/README.rst

@@ -57,6 +57,14 @@ To configure this module, you need to:
 Changelog
 =========
 
+13.0.1.2.2 (2020-08-30)
+~~~~~~~~~~~~~~~~~~~~~~~
+
+Fixes:
+
+- When using approve_sequence option in any tier.definition there can be inconsistencies in the systray notifications
+- When using approve_sequence, still not approve only the needed sequence, but also other sequence for the same approver
+
 12.0.3.3.1 (2019-12-02)
 ~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -162,6 +170,8 @@ Contributors
 * Adrià Gil Sorribes <[email protected]>
 * Pimolnat Suntian <[email protected]>
 * Saran Lim. <[email protected]>
+* Pedro Gonzalez <[email protected]>
+* Kitti U. <[email protected]>
 
 Maintainers
 ~~~~~~~~~~~

base_tier_validation/__manifest__.py

@@ -3,7 +3,7 @@
 {
     "name": "Base Tier Validation",
     "summary": "Implement a validation process based on tiers.",
-    "version": "12.0.3.7.0",
+    "version": "12.0.3.9.0",
     "development_status": "Mature",
     "maintainers": ['LoisRForgeFlow'],
     "category": "Tools",

base_tier_validation/data/mail_data.xml

@@ -1,6 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo noupdate="1">
-    <record id="mt_tier_validation_accepted" model="mail.message.subtype" forcecreate="1">
+    <record
+        id="mt_tier_validation_requested"
+        model="mail.message.subtype"
+        forcecreate="1"
+    >
+        <field name="name">Tier Validation Requested</field>
+        <field name="default" eval="True" />
+        <field name="internal" eval="True" />
+        <field name="hidden" eval="True" />
+    </record>
+    <record
+        id="mt_tier_validation_accepted"
+        model="mail.message.subtype"
+        forcecreate="1"
+    >
         <field name="name">Tier Validation Accepted Notification</field>
         <field name="default" eval="True"/>
         <field name="internal" eval="True"/>

base_tier_validation/i18n/da.po

@@ -17,7 +17,7 @@ msgstr ""
 "X-Generator: Weblate 3.9.1\n"
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_review.py:110
+#: code:addons/base_tier_validation/models/tier_review.py:111
 #, python-format
 msgid "%s (and %s more)"
 msgstr ""
@@ -35,25 +35,25 @@ msgid "<span class=\"oe_edit_only\">Name</span>"
 msgstr "<span class=\"oe_edit_only\">Navn</span>"
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_validation.py:310
+#: code:addons/base_tier_validation/models/tier_validation.py:329
 #, python-format
 msgid "A review has been requested by %s."
 msgstr "%s har anmodet om en godkendelse."
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_validation.py:232
+#: code:addons/base_tier_validation/models/tier_validation.py:254
 #, python-format
 msgid "A review was accepted"
 msgstr ""
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_validation.py:283
+#: code:addons/base_tier_validation/models/tier_validation.py:301
 #, python-format
 msgid "A review was rejected by %s."
 msgstr "En godkendelse var afvist af %s."
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_validation.py:180
+#: code:addons/base_tier_validation/models/tier_validation.py:187
 #, python-format
 msgid "A validation process is still open for at least one record."
 msgstr "En godkendelses proces er stadig igang for mindst en rekord."
@@ -77,8 +77,8 @@ msgstr "Alle"
 
 #. module: base_tier_validation
 #: selection:tier.definition,review_type:0
-msgid "Any user in a specific group."
-msgstr "En bruger i en specifik gruppe."
+msgid "Any user in a specific group"
+msgstr ""
 
 #. module: base_tier_validation
 #: model:ir.model.fields,help:base_tier_validation.field_tier_definition__approve_sequence
@@ -115,9 +115,15 @@ msgstr ""
 msgid "Cancel"
 msgstr "Annuller"
 
+#. module: base_tier_validation
+#: code:addons/base_tier_validation/models/tier_validation.py:204
+#, python-format
+msgid "Cannot write fields: %s"
+msgstr ""
+
 #. module: base_tier_validation
 #. openerp-web
-#: code:addons/base_tier_validation/models/tier_validation.py:244
+#: code:addons/base_tier_validation/models/tier_validation.py:259
 #: code:addons/base_tier_validation/static/src/xml/tier_review_template.xml:30
 #: model:ir.model.fields,field_description:base_tier_validation.field_comment_wizard__comment
 #: model:ir.model.fields,field_description:base_tier_validation.field_tier_definition__has_comment
@@ -157,7 +163,6 @@ msgid "Created on"
 msgstr "Oprettet d."
 
 #. module: base_tier_validation
-#: model:ir.model.fields,field_description:base_tier_validation.field_comment_wizard__definition_ids
 #: model:ir.model.fields,field_description:base_tier_validation.field_tier_definition__definition_type
 #: model:ir.model.fields,field_description:base_tier_validation.field_tier_review__definition_id
 msgid "Definition"
@@ -208,13 +213,23 @@ msgstr "Udført af"
 msgid "Done by"
 msgstr "Udført af"
 
+#. module: base_tier_validation
+#: selection:tier.definition,review_type:0
+msgid "Field in related record"
+msgstr ""
+
 #. module: base_tier_validation
 #: selection:tier.definition,definition_type:0
 msgid "Formula"
 msgstr "Formel"
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_review.py:103
+#: selection:tier.review,status:0
+msgid "Forwarded"
+msgstr ""
+
+#. module: base_tier_validation
+#: code:addons/base_tier_validation/models/tier_review.py:104
 #, python-format
 msgid "Group %s"
 msgstr ""
@@ -295,11 +310,6 @@ msgstr "Ingen godkendelser at foretage."
 msgid "Notify Reviewers on Creation"
 msgstr "Orienter godkendere ved oprettelse"
 
-#. module: base_tier_validation
-#: model:ir.model.fields,field_description:base_tier_validation.field_comment_wizard__object
-msgid "Object"
-msgstr ""
-
 #. module: base_tier_validation
 #. openerp-web
 #: code:addons/base_tier_validation/static/src/xml/systray.xml:33
@@ -359,6 +369,7 @@ msgstr ""
 #. module: base_tier_validation
 #. openerp-web
 #: code:addons/base_tier_validation/static/src/xml/systray.xml:13
+#: model:ir.model.fields,field_description:base_tier_validation.field_comment_wizard__review_ids
 #, python-format
 msgid "Review"
 msgstr "Gennemgang"
@@ -369,6 +380,12 @@ msgstr "Gennemgang"
 msgid "Reviewer"
 msgstr "Godkender"
 
+#. module: base_tier_validation
+#: model:ir.model.fields,field_description:base_tier_validation.field_tier_definition__reviewer_field_id
+#: model:ir.model.fields,field_description:base_tier_validation.field_tier_review__reviewer_field_id
+msgid "Reviewer field"
+msgstr ""
+
 #. module: base_tier_validation
 #: model:ir.model.fields,field_description:base_tier_validation.field_tier_definition__reviewer_group_id
 #: model:ir.model.fields,field_description:base_tier_validation.field_tier_review__reviewer_group_id
@@ -394,6 +411,7 @@ msgstr "Godkendelser"
 #. openerp-web
 #: code:addons/base_tier_validation/static/src/xml/tier_review_template.xml:23
 #: model:ir.model.fields,field_description:base_tier_validation.field_tier_definition__sequence
+#: model:ir.model.fields,field_description:base_tier_validation.field_tier_review__sequence
 #, python-format
 msgid "Sequence"
 msgstr "Rækkefølge"
@@ -412,13 +430,19 @@ msgid "Status"
 msgstr ""
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_validation.py:187
+#: code:addons/base_tier_validation/models/tier_validation.py:194
 #, python-format
 msgid "The operation is under validation."
 msgstr "Operationen er under godkendelse."
 
 #. module: base_tier_validation
-#: code:addons/base_tier_validation/models/tier_validation.py:176
+#: code:addons/base_tier_validation/models/tier_review.py:123
+#, python-format
+msgid "There are no res.users in the selected field"
+msgstr ""
+
+#. module: base_tier_validation
+#: code:addons/base_tier_validation/models/tier_validation.py:183
 #, python-format
 msgid ""
 "This action needs to be validated for at least one record. \n"
@@ -427,11 +451,6 @@ msgstr ""
 "Denne handling behøver godkendelse for minimum en rekord.\n"
 "Anmod venligst om en godkendelse."
 
-#. module: base_tier_validation
-#: model:ir.model.fields,field_description:base_tier_validation.field_tier_review__sequence
-msgid "Tier"
-msgstr "Trin"
-
 #. module: base_tier_validation
 #: model:ir.actions.act_window,name:base_tier_validation.tier_definition_action
 #: model:ir.model,name:base_tier_validation.model_tier_definition
@@ -462,6 +481,11 @@ msgstr ""
 msgid "Tier Validation Rejected Notification"
 msgstr ""
 
+#. module: base_tier_validation
+#: model:mail.message.subtype,name:base_tier_validation.mt_tier_validation_requested
+msgid "Tier Validation Requested"
+msgstr ""
+
 #. module: base_tier_validation
 #: model:ir.ui.menu,name:base_tier_validation.menu_tier_confirmation
 msgid "Tier Validations"
@@ -484,6 +508,11 @@ msgstr ""
 msgid "Users"
 msgstr "Brugere"
 
+#. module: base_tier_validation
+#: model:ir.model.fields,field_description:base_tier_validation.field_tier_definition__valid_reviewer_field_ids
+msgid "Valid Reviewer Field"
+msgstr ""
+
 #. module: base_tier_validation
 #: model:ir.model.fields,field_description:base_tier_validation.field_comment_wizard__validate_reject
 msgid "Validate Reject"
@@ -518,5 +547,11 @@ msgstr "Godkendelser"
 msgid "e.g. Tier Validation for..."
 msgstr ""
 
+#~ msgid "Tier"
+#~ msgstr "Trin"
+
+#~ msgid "Any user in a specific group."
+#~ msgstr "En bruger i en specifik gruppe."
+
 #~ msgid "Approve Sequence"
 #~ msgstr "Godkendelsesrækkefølge"