Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup initial pipeline #3

Closed
davidhoelzel opened this issue Feb 21, 2024 · 0 comments · Fixed by #7
Closed

Setup initial pipeline #3

davidhoelzel opened this issue Feb 21, 2024 · 0 comments · Fixed by #7
Assignees

Comments

@davidhoelzel
Copy link
Member

davidhoelzel commented Feb 21, 2024

Code quality tools:

  • php-cs-fixer
  • phpstan
    • to be discussed as most symfony bundles do not use it either (mostly due to redundant array-shape definitions etc.)
  • phpunit

For phpunit, the setup in the application is already done (version 10.5) without the symfony unit bridge.

Perhaps we should add a code-coverage badge as this will be a public bundle.

@davidhoelzel davidhoelzel self-assigned this Mar 8, 2024
davidhoelzel added a commit that referenced this issue Mar 8, 2024
davidhoelzel added a commit that referenced this issue Mar 11, 2024
davidhoelzel added a commit that referenced this issue Mar 11, 2024
- use interface instead of class
@davidhoelzel davidhoelzel linked a pull request Mar 13, 2024 that will close this issue
davidhoelzel added a commit that referenced this issue Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant