Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Php-Parser from 4 to 5 for PHP8.4 support #1426

Open
gennadigennadigennadi opened this issue Jul 4, 2024 · 4 comments · Fixed by qossmic/deptrac-src#103
Open

Upgrade Php-Parser from 4 to 5 for PHP8.4 support #1426

gennadigennadigennadi opened this issue Jul 4, 2024 · 4 comments · Fixed by qossmic/deptrac-src#103

Comments

@gennadigennadigennadi
Copy link
Member

gennadigennadigennadi commented Jul 4, 2024

Right now psalm blocks this.

@patrickkusebauch
Copy link
Collaborator

I successfully used https://github.com/bamarni/composer-bin-plugin to separate dev-dependencies (like Psalm) from production dependencies and unblock production dependency upgrades. Maybe it could be used here as well.

@gennadigennadigennadi
Copy link
Member Author

Maybe using composer-bin-plugin would help here.

Right now the upgrade blocks PHP8.4 support

@gennadigennadigennadi gennadigennadigennadi changed the title Upgrade Php-Parser from 4 to 5 Upgrade Php-Parser from 4 to 5 for PHP8.4 support Nov 21, 2024
@gennadigennadigennadi
Copy link
Member Author

Migrated the dev reqs to composer-bin-plugin, next steps would be to migrate to phpparser v5.

@pkruithof
Copy link

Seeing as qossmic/deptrac-src#103 is merged, when can we expect a new release with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants