Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for passing option defaults via environment variables #50

Open
SpComb opened this issue Jul 2, 2020 · 0 comments
Open

Support for passing option defaults via environment variables #50

SpComb opened this issue Jul 2, 2020 · 0 comments
Labels

Comments

@SpComb
Copy link
Member

SpComb commented Jul 2, 2020

The various command-line options defined by the packages should use the go-flags env, env-delim support to allow passing options via environment variables.

This would make configuring the EnvironmentFile=/etc/default/qmsk-e2-tally options much easier in terms of syntax: #49

I do want to mention that the file for the designation of the Tally GPIO pins needs to be addressed. In the /etc/default qmsk-e2-tally file, not only do you have to remove the comments "#", but there is an extra blank line that needs to be removed as well.

The go-flags package that we use supports setting option default values from environment variables, so the tally gpio options could be improved to support separate environment variables like TALLY_GPIO_PIN_GREEN=23, TALLY_GPIO_PIN_RED=24, TALLY_GPIO_PINS=... etc, which would make the /etc/default/qmsk-e2-tally much easier to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant