Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB matrix - hue_steps vs RGB_MATRIX_HUE_STEP (multiple vs single) #24670

Open
fightforlife opened this issue Dec 3, 2024 · 0 comments
Open

Comments

@fightforlife
Copy link

Issue Description

I recently noticed that there is a difference in naming for the 4 STEP defines in json vs c.

  • In json it is called e.g. "sat_steps: 8" (multiple), which suggests that there are 8 steps between no and full saturation. Increasing these steps would result in finer control.
  • in C it is called e.g."RGB_MATRIX_SAT_STEP=8" (singular), which suggests that each time you increase/decreaste saturation, it will go 8 off 255 steps down or up. Increasing this step would result in less control.

The problem is, that the first interpretation and the second interpretation are contrary..
In the Code it looks like the second / C interpretation is correct.

rgb_matrix_sethsv_eeprom_helper(rgb_matrix_config.hsv.h + RGB_MATRIX_HUE_STEP, rgb_matrix_config.hsv.s, rgb_matrix_config.hsv.v, write_to_eeprom);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant