You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I recently noticed that there is a difference in naming for the 4 STEP defines in json vs c.
In json it is called e.g. "sat_steps: 8" (multiple), which suggests that there are 8 steps between no and full saturation. Increasing these steps would result in finer control.
in C it is called e.g."RGB_MATRIX_SAT_STEP=8" (singular), which suggests that each time you increase/decreaste saturation, it will go 8 off 255 steps down or up. Increasing this step would result in less control.
The problem is, that the first interpretation and the second interpretation are contrary..
In the Code it looks like the second / C interpretation is correct.
Issue Description
I recently noticed that there is a difference in naming for the 4 STEP defines in json vs c.
The problem is, that the first interpretation and the second interpretation are contrary..
In the Code it looks like the second / C interpretation is correct.
qmk_firmware/quantum/rgb_matrix/rgb_matrix.c
Line 608 in 191172a
The text was updated successfully, but these errors were encountered: