This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
Generate translated version of qmk.fm/keyboards page #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While its cool to see the effort put into this, unfortunately the process that publishes binaries no longer runs. The content is rather stale, and because of this, changes like this are unlikely to be accepted. The whole site is planned to be replaced at some point, with a few PoC having been put together. The page itself is due to be removed/replaced by a different process, however its yet to be decided how the whole thing will hang together. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've made some changes to allow the auto-generated keyboards page to allow for translations 😄
generate_keyboard_page.pyto work with multiple languages instead of being hardcoded to English.i18nfolder inside of_utilsdirectory. Each language needs a folder matching its language code.Thankfully I know Spanish, so I was able to create an
esdirectory and file as an example. I've tested the python script locally and have included the updated en and new es keyboard pages in this PR. I've also tested the GitHub workflow locally using https://github.com/nektos/act.Please let me know your thoughts! I'm happy to make any changes necessary.
Fixes https://github.com/qmk/qmk.fm/issues/89