You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The default TCR beta model_parms.txt contains extraneous information from the IMGT where, ideally, only the name of the allele should be. Compare this to the model_parms.txt files for IGL, IGK, IGH, and TCR alpha. While this extra information doesn't present a problem for IGoR to my knowledge, it has consequential downstream effects. In particular, OLGA, and therefore SONIA or soNNia, requires only the name of the allele to precede the allele sequence in the model_params.txt, which is taken as the final_parms.txt file from a custom-trained IGoR model. Notably the default TCR beta OLGA model doesn't have this extra IMGT information.
Training a TCR beta model without supplying a model_parms.txt would ensue in the final_parms.txt of the custom model being roughly identical to the default model_parms.txt file with the extra IMGT information present (but with a different error rate). At this moment in time, OLGA does not raise an exception if the name of the allele is not the only piece of information preceding the allele sequence, so a user with a custom TCR beta model from IGoR would not know what the problem is. While there are fixes to be made in OLGA to ensure the user knows when parsing/input file errors are encountered, it would set up everyone for success if the superfluous IMGT information was removed from the default TCR beta mode_parms.txt.
I've attached what I believe should be the default TCR beta model_parms.txt, with the IMGT information removed for the alleles: model_parms.txt.
Thanks and take good care,
Zach
The text was updated successfully, but these errors were encountered:
The default TCR beta
model_parms.txt
contains extraneous information from the IMGT where, ideally, only the name of the allele should be. Compare this to themodel_parms.txt
files for IGL, IGK, IGH, and TCR alpha. While this extra information doesn't present a problem for IGoR to my knowledge, it has consequential downstream effects. In particular, OLGA, and therefore SONIA or soNNia, requires only the name of the allele to precede the allele sequence in themodel_params.txt
, which is taken as thefinal_parms.txt
file from a custom-trained IGoR model. Notably the default TCR beta OLGA model doesn't have this extra IMGT information.Training a TCR beta model without supplying a
model_parms.txt
would ensue in thefinal_parms.txt
of the custom model being roughly identical to the defaultmodel_parms.txt
file with the extra IMGT information present (but with a different error rate). At this moment in time, OLGA does not raise an exception if the name of the allele is not the only piece of information preceding the allele sequence, so a user with a custom TCR beta model from IGoR would not know what the problem is. While there are fixes to be made in OLGA to ensure the user knows when parsing/input file errors are encountered, it would set up everyone for success if the superfluous IMGT information was removed from the default TCR betamode_parms.txt
.I've attached what I believe should be the default TCR beta
model_parms.txt
, with the IMGT information removed for the alleles:model_parms.txt.
Thanks and take good care,
Zach
The text was updated successfully, but these errors were encountered: