Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality #5

Open
MitchAnderson93 opened this issue May 16, 2024 · 4 comments
Open

Functionality #5

MitchAnderson93 opened this issue May 16, 2024 · 4 comments
Assignees

Comments

@MitchAnderson93
Copy link
Member

MitchAnderson93 commented May 16, 2024

The current state

  • Designer (actor) syncs token.json to repo (figma/tokens.json folder, via figma and the token studio plugin)
  • Should create an automatic pull request to main (notifying the development team)
  • On merge (in the developer process) a patch/minor/major release type is selected
  • This takes care of semver number and release to github packages and npm packages (see guide on the right of the repository)

Current testing

  • Upload new token with changed warning colours, changed warning colours should not carry over (instead, they are replaced by the static vars in the repository)

How do we test/gaps

  • Count the variables and ensure they match the number of total palette colours (in JEST right now, needs count added)
  • Perform an integrity test against a committed change set file?
    e.g. Designer not only performs the sync, but also declares the changing variable name in a committed change set file. This can be utilised for further change control, and for delta purposes (if an extra change is detected and not declared, fail gracefully and inform the team).

Missing

  • Status colours such as warning/info/critical should never be overridden (even if done so in Figma). The repository should always use a static copy for final dist (that can't change).
  • Support for icons.svg (sprite), crest/logo variations (potentially used in use by CDN).
  • Support for niche conventions like drop shadow/box shadow etc.
  • Automatic support for multi-brand/multi-palettes e.g. Dan pushes a new token.json (as DES-token.json) to ./figma. This should create a seperate dist for this, using part of the file name (seperate, inteded for DES).
@MitchAnderson93
Copy link
Member Author

Let me know your thoughts @duttonw

@MitchAnderson93
Copy link
Member Author

Keen to hear your thoughts @ThrawnCA and @chris-randall-qol

@ThrawnCA
Copy link

Should there be an intermediate 'develop' branch before merging to main? We use that in several other places to represent bleeding-edge changes.

@duttonw
Copy link
Member

duttonw commented May 16, 2024

Depending on the maturity of the design having it auto cron into develop on a daily basis to build latest and assigning a team to review and version point cut or have it raise a PR per day to master with date in the PR name to have it flesh out. Could also add list of Parma added, changed to the pr that could propagate to the auto release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants