Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please rewrite this on ES6 and remove require of assert in the production build #9

Open
talamaska opened this issue May 28, 2019 · 0 comments

Comments

@talamaska
Copy link

I do realise that this library was created long ago when js didn't had classes but now it is different.
The require of assert is really another specific issue for using the library in electron.
It is recommended to have nodeIntegration turned off, this means that any require will not work, but if it is import, that'ss another story and might just work.
And last time I used assert was for tests or otherthings done only in dev build, not in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant