Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When processing arrays, can't distinguish between numerical and string item which has the "same" value #10

Open
passionwdy opened this issue Aug 11, 2020 · 0 comments
Open

When processing arrays, can't distinguish between numerical and string item which has the "same" value #10

passionwdy opened this issue Aug 11, 2020 · 0 comments

Comments

@passionwdy
Copy link

example
findLongestMatch(1234, '1234') will return [0, 0, 1].

I guess the main reason is some object keys do not contain type info. For example in the SequenceMatcher.prototype._chainB function when generate b2j, elt should add the result of typeof elt. Like this elt = typeof elt + elt.
ewoudenberg pushed a commit to ewoudenberg/difflib.js that referenced this issue Dec 8, 2021
@ewoudenberg-kasisto
Fix bug where numbers and strings were not differentiated (Fixes issue …
a5908c0 
…qiao#10).

Update build scripts and npm dependencies.
Add unit test for issue qiao#10.
@ewoudenberg ewoudenberg mentioned this issue Dec 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@passionwdy