From d82c2dc2ebca1b85618585c6dc83f1062faa0116 Mon Sep 17 00:00:00 2001
From: "Filipe Oliveira (Personal)" <filipecosta.90@gmail.com>
Date: Mon, 5 Aug 2024 11:28:26 +0300
Subject: [PATCH]  Updated milvus from 2.3.1 to 2.4.1  (#144)

* updated milvus from 2.3.1 to 2.4.1

* Fixed json logging numeric/text issue on docker composes of milvus
---
 .../servers/milvus-limit-ram/docker-compose.yaml   |  2 +-
 .../servers/milvus-single-node/docker-compose.yaml | 14 +++++++-------
 pyproject.toml                                     |  2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/engine/servers/milvus-limit-ram/docker-compose.yaml b/engine/servers/milvus-limit-ram/docker-compose.yaml
index 888b9b9c..948b868b 100644
--- a/engine/servers/milvus-limit-ram/docker-compose.yaml
+++ b/engine/servers/milvus-limit-ram/docker-compose.yaml
@@ -39,7 +39,7 @@ services:
 
   standalone:
     container_name: milvus-standalone
-    image: milvusdb/milvus:v2.3.1
+    image: milvusdb/milvus:v2.4.1
     command: ["milvus", "run", "standalone"]
     environment:
       ETCD_ENDPOINTS: etcd:2379
diff --git a/engine/servers/milvus-single-node/docker-compose.yaml b/engine/servers/milvus-single-node/docker-compose.yaml
index 7fe7a56d..02fe4d0b 100644
--- a/engine/servers/milvus-single-node/docker-compose.yaml
+++ b/engine/servers/milvus-single-node/docker-compose.yaml
@@ -14,8 +14,8 @@ services:
     logging:
       driver: "json-file"
       options:
-        max-file: 1
-        max-size: 10m
+        max-file: "1"
+        max-size: "10m"
     command: etcd -advertise-client-urls=http://127.0.0.1:2379 -listen-client-urls http://0.0.0.0:2379 --data-dir /etcd
 
   minio:
@@ -29,8 +29,8 @@ services:
     logging:
       driver: "json-file"
       options:
-        max-file: 1
-        max-size: 10m
+        max-file: "1"
+        max-size: "10m"
     command: minio server /minio_data
     healthcheck:
       test: ["CMD", "curl", "-f", "http://localhost:9000/minio/health/live"]
@@ -40,7 +40,7 @@ services:
 
   standalone:
     container_name: milvus-standalone
-    image: milvusdb/milvus:v2.3.1
+    image: milvusdb/milvus:v2.4.1
     command: ["milvus", "run", "standalone"]
     environment:
       ETCD_ENDPOINTS: etcd:2379
@@ -48,8 +48,8 @@ services:
     logging:
       driver: "json-file"
       options:
-        max-file: 1
-        max-size: 10m
+        max-file: "1"
+        max-size: "10m"
     ports:
       - "19530:19530"
     depends_on:
diff --git a/pyproject.toml b/pyproject.toml
index bc8b5c82..5bc02a5f 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -12,7 +12,7 @@ jsons = "^1.6.3"
 h5py = "^3.7.0"
 weaviate-client = "^4.5.0"
 elasticsearch = "^8.10.0"
-pymilvus = "^2.3.1"
+pymilvus = "^2.4.1"
 redis = "^5.0.1"
 ipdb = "^0.13.9"
 stopit = "^1.1.2"