Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow JWT/RBAC write access with payload filters, link to access table #189

Open
timvisee opened this issue Jun 19, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@timvisee
Copy link
Member

The JWT/RBAC access settings dialog currently greys out the 'Payload Filters' section if write operations are checked.

Payload filters are supported when write access is enabled, and so it should not be greyed out when write access is selected.

image

To help clarify this, we might want to add a [Access table] link in the dialog.

@timvisee timvisee added the bug Something isn't working label Jun 19, 2024
@generall
Copy link
Member

generall commented Jul 8, 2024

Write operation support is quite limited and might be confusing if applied without checking on the documentation. I would prefer to keep it as-is for now

@timvisee
Copy link
Member Author

timvisee commented Jul 9, 2024

The problem is this: if you disable write operations, you can edit the payload filters. If you then enable writes again, these filters stay. It feels like a hack and makes it only more confusing.

image

I think we should choose one of:

  1. allow payload filters with write operations
  2. if enabling write operations, clear and grey out the payload filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants