Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Persist snippets language preference #900

Closed
wants to merge 1 commit into from
Closed

Conversation

Anush008
Copy link
Member

@Anush008 Anush008 commented May 15, 2024

Resolves #899

PREVIEW

Copy link

netlify bot commented May 15, 2024

Deploy Preview for condescending-goldwasser-91acf0 ready!

Name Link
🔨 Latest commit eca52c6
🔍 Latest deploy log https://app.netlify.com/sites/condescending-goldwasser-91acf0/deploys/66449c0cf138a0000845f026
😎 Deploy Preview https://deploy-preview-900--condescending-goldwasser-91acf0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anush008 Anush008 changed the title feat: lang preference persist feat: Persist snippets language preference May 15, 2024
@trean
Copy link
Collaborator

trean commented May 17, 2024

Thanks for the feature @Anush008!
We are moving to the new site theme very soon and it means we will abandon this code.

Let's try to implement it in the new theme. WDYT?

But it would be good to think about how it can work more smoothly. Now if language changes on a snippet in the middle or the end of the page it makes the whole page jump.
Maybe you know examples of sites where you like how similar functionality works?

@Anush008
Copy link
Member Author

Anush008 commented May 17, 2024

Let's try to implement it in the new theme. WDYT?

Yes. Thanks.

Now if language changes on a snippet in the middle or the end of the page it makes the whole page jump.

Right. It's very evident and surprising.

Maybe you know examples of sites where you like how similar functionality works?

Not yet. From discussions, they're usually different pages per code block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Choosing language in one snippet should change language in others
2 participants