New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistency with paper #4

Open

willleeney opened this issue Feb 21, 2024 · 0 comments

willleeney commented Feb 21, 2024

the current code runs with B not concat(B,X) as detailed in the paper, as it is currently commented out.

Also the kl divergence loss in line 141 doesn't need the logits.size(0) division as you are already taking the mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment