[linux] fix explicit constructors for structs

Author: q4a

src/apps/engine/src/script_cache.h

@@ -15,10 +15,8 @@ struct FunctionLocalVariable
     LocalVarInfo info;
     bool is_extern;
 
-    FunctionLocalVariable(LocalVarInfo info, bool is_extern)
+    FunctionLocalVariable(LocalVarInfo info, bool is_extern) : info(std::move(info)), is_extern(std::move(is_extern))
     {
-        this->info = info;
-        this->is_extern = is_extern;
     }
 };
 
@@ -29,9 +27,8 @@ struct Function
     std::vector<LocalVarInfo> local_variables;
 
     Function(FuncInfo info, std::vector<FunctionLocalVariable> arguments)
+        : info(std::move(info)), arguments(std::move(arguments))
     {
-        this->info = info;
-        this->arguments = arguments;
     }
 };
 
@@ -41,9 +38,8 @@ struct EventHandler
     std::string function_name;
 
     EventHandler(std::string event_name, std::string function_name)
+        : event_name(std::move(event_name)), function_name(std::move(function_name))
     {
-        this->event_name = event_name;
-        this->function_name = function_name;
     }
 };
 
@@ -54,10 +50,8 @@ struct Define
     uintptr_t value;
 
     Define(std::string name, uint32_t type, uintptr_t value)
+        : name(std::move(name)), type(std::move(type)), value(std::move(value))
     {
-        this->name = name;
-        this->type = type;
-        this->value = value;
     }
 };
 

src/libs/common/include/dx9render.h

@@ -50,10 +50,8 @@ struct RS_LINE
     RS_LINE()
     {
     }
-    RS_LINE(CVECTOR vPos, uint32_t dwColor)
+    RS_LINE(CVECTOR vPos, uint32_t dwColor) : vPos(std::move(vPos)), dwColor(std::move(dwColor))
     {
-        this->vPos = vPos;
-        this->dwColor = dwColor;
     }
 };
 

src/libs/location/src/lights.h

@@ -59,10 +59,8 @@ class Lights : public Entity
         int32_t id;
         int32_t light;
 
-        MovingLight(int32_t id, int32_t light)
+        MovingLight(int32_t id, int32_t light) : id(std::move(id)), light(std::move(light))
         {
-            this->id = id;
-            this->light = light;
         }
     };
 

src/libs/location/src/supervisor.h

@@ -34,12 +34,8 @@ class Supervisor
         float d2;         // The square of the distance to the character in xz
 
         FindCharacter(Character *c, float dx, float dy, float dz, float d2)
+            : c(std::move(c)), dx(std::move(dx)), dy(std::move(dy)), dz(std::move(dz)), d2(std::move(d2))
         {
-            this->c = c;
-            this->dx = dx;
-            this->dy = dy;
-            this->dz = dz;
-            this->d2 = d2;
         }
     };
 
@@ -48,10 +44,8 @@ class Supervisor
         Character *c;
         float lastTime;
 
-        CharacterEx(Character *c, float lastTime)
+        CharacterEx(Character *c, float lastTime) : c(std::move(c)), lastTime(std::move(lastTime))
         {
-            this->c = c;
-            this->lastTime = lastTime;
         }
     };
 

src/libs/sea_ai/src/ai_ship_cannon_controller.cpp

@@ -636,10 +636,8 @@ void AIShipCannonController::Realize(float fDeltaTime)
         CVECTOR vPos;
         uint32_t dwColor;
 
-        tr_vertex(CVECTOR vPos, uint32_t dwColor)
+        tr_vertex(CVECTOR vPos, uint32_t dwColor) : vPos(std::move(vPos)), dwColor(std::move(dwColor))
         {
-            this->vPos = vPos;
-            this->dwColor = dwColor;
         }
     };