Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why can't tracker entrypoint be specified in .torchxconfig #802

Open
clumsy opened this issue Dec 18, 2023 · 2 comments
Open

Why can't tracker entrypoint be specified in .torchxconfig #802

clumsy opened this issue Dec 18, 2023 · 2 comments

Comments

@clumsy
Copy link
Contributor

clumsy commented Dec 18, 2023

❓ Questions and Help

Please note that this issue tracker is not a help form and this issue will be closed.

Before submitting, please ensure you have gone through our
documentation.

Question

The documentation is somewhat confusing and is marked for Advanced use after mentioning the mechanism to reference entrypoint, but is there a reason we can't also specify the tracker's entrypoint right in .torchxconfig in addition to those discoverable via entry_points.txt? E.g.:

[torchx:tracker]
my_tracker=my_module:my_function

[tracker:my_tracker]
...
@clumsy
Copy link
Contributor Author

clumsy commented Dec 18, 2023

If there's no strong reason not to - I can contribute, @kiukchung. Especially since hydra is already in the dependencies we can simply use hydra.utils.get_method/hydra.utils.call

@kurman
Copy link
Contributor

kurman commented Dec 19, 2023

@clumsy I don't think there is a strong reason, feel free to contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants