Skip to content

[Compiler Toolkit] Improve compiler toolkit logging #2028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fegin wants to merge 3 commits into from
Closed

[Compiler Toolkit] Improve compiler toolkit logging #2028

fegin wants to merge 3 commits into from

Conversation

@fegin
Copy link
Contributor

@fegin fegin commented Nov 12, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Summary:

  1. When an input is not a DTensor, print out its index and type.
  2. Graph dump spams the initialization log, make it to debug level and output the graphs to the dump folder.

@fegin
Update
979fdbd 
[ghstack-poisoned]
This was referenced Nov 12, 2025
Merged
Merged
Merged
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 12, 2025
@fegin
Update
be7e486 
[ghstack-poisoned]
@fegin fegin requested a review from yiming0416 November 12, 2025 21:48
@fegin fegin mentioned this pull request Nov 12, 2025
Merged
@fegin fegin changed the title Improve compiler toolkit logging [Compiler Toolkit] Improve compiler toolkit logging Nov 12, 2025
fegin added a commit that referenced this pull request Nov 13, 2025
@fegin
Add .claude to .gitignore (#2026)
4b2b31c 
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0)
(oldest at bottom):
* #2029
* #2030
* #2028
* #2027
* __->__ #2026

As title
fegin added a commit that referenced this pull request Nov 13, 2025
@fegin
Fix dry run mode (#2027)
ce1c0fc 
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0)
(oldest at bottom):
* #2029
* #2030
* #2028
* __->__ #2027
* #2026

Dry run mode works but it doesn't exit gracefully for all cases. This PR
fixes it

```
DRY_RUN=1 CONFIG_FILE="./torchtitan/models/llama3/train_configs/debug_model.toml" ./run_train.sh   --training.steps=10 --activation_checkpoint.mode="none"
--debug.deterministic --debug.seed=42
```
@fegin fegin changed the base branch from gh/fegin/37/base to main November 13, 2025 07:47
@fegin fegin changed the base branch from main to gh/fegin/37/base November 13, 2025 07:48
@fegin fegin changed the base branch from gh/fegin/37/base to main November 13, 2025 07:52
@fegin fegin changed the base branch from main to gh/fegin/37/base November 13, 2025 07:52
@fegin
Update
097d547 
[ghstack-poisoned]
@fegin fegin changed the base branch from gh/fegin/37/base to main November 13, 2025 07:57
@fegin fegin changed the base branch from main to gh/fegin/37/base November 13, 2025 07:59
@fegin fegin changed the base branch from gh/fegin/37/base to main November 13, 2025 08:07
@fegin fegin changed the base branch from main to gh/fegin/37/base November 13, 2025 08:11
fegin added a commit that referenced this pull request Nov 13, 2025
@fegin
[Compiler Toolkit] Make compiler toolkit work with checkpoint (#2030)
e7ee95a 
Stack from [ghstack](https://github.com/ezyang/ghstack/tree/0.12.0)
(oldest at bottom):
* #2029
* __->__ #2030

The current CompileModule will result in an "inner" prefix for
everything. This
PR fixes it by overloading the methods.

Also merge #2028 to this PR.
Something wrong with ghstack.
@fegin fegin closed this Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiming0416 yiming0416 yiming0416 approved these changes

@tianyu-l tianyu-l Awaiting requested review from tianyu-l

@wwwjn wwwjn Awaiting requested review from wwwjn

@wconstab wconstab Awaiting requested review from wconstab

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fegin @yiming0416