Arm backend: Simplify testing of int inputs #15701
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15701
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 6 Unrelated FailuresAs of commit 7bd16d2 with merge base 2aeee9b ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
Collaborator
|
Some arm tests fails :( |
INT-test pipelines always checked that quantized models produced quantize and dequantize nodes, and that these are removed in to_edge. This meant that when you add a test with inputs that do not need to be quantized, e.g. integer and boolean inputs, you would have to pop those stages from the test pipeline. This patch removes the need for popping those stages by making sure that they are only added if at least one input is in floating point. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I51220b719dfd19e3a4c109e23de544fea374333c
oscarandersson8218
force-pushed
the
int_inputs_testing_improvement
branch
from
871a7b7 to
7bd16d2
Compare
Collaborator
|
@SS-JIA Hi here is a many files PR again :) |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INT-test pipelines always checked that quantized models produced quantize and dequantize nodes, and that these are removed in to_edge. This meant that when you add a test with inputs that do not need to be quantized, e.g. integer and boolean inputs, you would have to pop those stages from the test pipeline.
This patch removes the need for popping those stages by making sure that they are only added if at least one input is in floating point.
cc @freddan80 @per @zingo @digantdesai