Skip to content

ARM baremetal tests are not running properly #9602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jathu opened this issue Mar 25, 2025 · 1 comment · May be fixed by #10517
Open

ARM baremetal tests are not running properly #9602

jathu opened this issue Mar 25, 2025 · 1 comment · May be fixed by #10517
Assignees
Labels
module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm

Comments

@jathu
Copy link
Contributor

jathu commented Mar 25, 2025

While working on https://github.com/pytorch/executorch/pull/9583/files, I noticed that unittest-arm in .github/workflows/pull.yml, configured EXECUTORCH_BUILD_ARM_BAREMETAL to be on via an environment variable. As far as I can tell, this does not automatically propagate the flag to a CMake arg. Thus, I suspect this CI flow has not been testing with EXECUTORCH_BUILD_ARM_BAREMETAL enabled.

I tried enabled it via CMAKE_ARGS, but it results in build failures! Passing this to the ARM team to look further into this.

cc @larryliu0820 @lucylq @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mergennachin

@jathu jathu added the module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch label Mar 25, 2025
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Mar 25, 2025
@zingo zingo removed their assignment Mar 26, 2025
@zingo
Copy link
Collaborator

zingo commented Mar 27, 2025

Interesting this might just work by pure luck right now as we are not running on target in this job. We check this out.

@zingo zingo self-assigned this Apr 25, 2025
zingo added a commit to zingo/executorch that referenced this issue Apr 28, 2025
Inception_v4 and w2l for Ethos-U85
Inception_v3/4, w2l and resnet18/50 for TOSA

Make it possible to override default runtime timeout per test

This also split up GitHub testing in a few separate runners
to speed up the testing as it takes longer then 60min.

This also fix pytorch#9602 where arm unittest didn't build
Executorch with EXECUTORCH_BUILD_ARM_BAREMETAL enabled

Signed-off-by: Zingo Andersen <[email protected]>
Change-Id: I6e1b6ec18c450896aa4e7b5d7a37d27c4c7f879d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: build/install Issues related to the cmake and buck2 builds, and to installing ExecuTorch partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants