-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QOL: easy way to run lint locally that matches the behavior in CI #1448
Comments
yeah I already added it: https://github.com/pytorch/ao/blob/main/scripts/run_ruff_fix.sh does this work for you? |
can we make both CI and that script use the same rules, so the chance of divergence from future PRs is reduced? |
yeah I also commented with the same before, although I looked again and CI is doing |
Added here: #1450 |
Updated here: #1453 For more context the way to do this is to use
|
We have the CI lint rules here: https://github.com/pytorch/ao/blob/main/.github/workflows/ruff_linter.yml , currently expressed as
It would be nice to have this logic be reusable, so I can run it locally with something like
./lint_my_code.sh
and know that CI will be green. I used to do this withruff format .
, but that no longer matches the CI logic, slowing down the iteration cycle on PRs that passruff format .
but fail the more extensive checks.The text was updated successfully, but these errors were encountered: