Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--op-collection misses layernorm #103

Open
FindHao opened this issue Dec 7, 2024 · 1 comment
Open

--op-collection misses layernorm #103

FindHao opened this issue Dec 7, 2024 · 1 comment
Assignees

Comments

@FindHao
Copy link
Member

FindHao commented Dec 7, 2024

The liger operator collection doesn't include layernorm because the operator collection either has an op or not. Since liger's layernorm is added into existing op folder, it is skipped in liger op-collection. We need to specifically include layernorm in both default and liger op collection.

@FindHao FindHao self-assigned this Dec 7, 2024
@xuzhao9
Copy link
Contributor

xuzhao9 commented Dec 7, 2024

It makes sense to me to have overlapping op collections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants