Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--output is not compatible with --op-collection #101

Open
FindHao opened this issue Dec 6, 2024 · 2 comments
Open

--output is not compatible with --op-collection #101

FindHao opened this issue Dec 6, 2024 · 2 comments
Assignees
@FindHao

Comments

@FindHao
Copy link
Member

FindHao commented Dec 6, 2024

Since the --dump-csv is replaced with --output, we have to specify the output file path when dumping csv. However, --op-collection mode can't specify a single output file path.
@xuzhao9
Copy link
Contributor

xuzhao9 commented Dec 7, 2024

Lets error out when both --output and --op-collection is specified. When --op-collection is specified, we require a --output-dir to dump the output to a directory.

@FindHao
Copy link
Member Author

FindHao commented Dec 7, 2024

Lets error out when both --output and --op-collection is specified. When --op-collection is specified, we require a --output-dir to dump the output to a directory.

sounds good to me. will do it this way.

@FindHao FindHao self-assigned this Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FindHao FindHao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xuzhao9 @FindHao