fix: PR review 반영

Author: earthyoung

.pre-commit-config.yaml

@@ -1,81 +1,84 @@
 # See https://pre-commit.com for more information
 # See https://pre-commit.com/hooks.html for more hooks
 default_language_version:
-    python: python3.12
+  python: python3.12
 default_stages: [pre-commit, pre-push]
 repos:
-- repo: https://github.com/pre-commit/pre-commit-hooks
-  rev: v5.0.0
-  hooks:
-  - id: check-toml
-  - id: check-xml
-  - id: check-yaml
-  - id: check-added-large-files
-  - id: detect-aws-credentials
-    args:
-      - --allow-missing-credentials
-  - id: end-of-file-fixer
-  - id: mixed-line-ending
-  - id: pretty-format-json
-    args:
-      - --autofix
-  - id: trailing-whitespace
-    exclude_types:
-      - javascript
-      - markdown
-- repo: https://github.com/PyCQA/flake8
-  rev: 7.2.0
-  hooks:
-  - id: flake8
-    additional_dependencies:
-      - flake8-bugbear
-      - flake8-noqa
-    args:
-      - --max-line-length=120
-      - --max-complexity=18
-- repo: https://github.com/psf/black
-  rev: 25.1.0
-  hooks:
-  - id: black
-    language_version: python3.12
-    args:
-      - --line-length=120
-- repo: https://github.com/PyCQA/bandit
-  rev: '1.8.3'
-  hooks:
-  - id: bandit
-- repo: https://github.com/PyCQA/isort
-  rev: '6.0.1'
-  hooks:
-    - id: isort
-- repo: https://github.com/dosisod/refurb
-  rev: v2.0.0
-  hooks:
-    - id: refurb
-      additional_dependencies:
-        - boto3
-        - django-constance
-        - django-cors-headers
-        - django-environ
-        - django-extensions
-        - django-filter
-        - django-simple-history
-        - django-stubs[compatible-mypy]
-        - drf-spectacular
-        - drf-standardized-errors
-        - djangorestframework-stubs[compatible-mypy]
-        - zappa-django-utils
-- repo: https://github.com/astral-sh/uv-pre-commit
-  rev: 0.6.12
-  hooks:
-    - id: uv-lock
-- repo: https://github.com/astral-sh/ruff-pre-commit
-  rev: v0.11.4
-  hooks:
-    - id: ruff
-      args:
-        - --fix
-    - id: ruff-format
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v5.0.0
+    hooks:
+      - id: check-toml
+      - id: check-xml
+      - id: check-yaml
+      - id: check-added-large-files
+      - id: detect-aws-credentials
+        args:
+          - --allow-missing-credentials
+      - id: end-of-file-fixer
+      - id: mixed-line-ending
+      - id: pretty-format-json
+        args:
+          - --autofix
+      - id: trailing-whitespace
+        exclude_types:
+          - javascript
+          - markdown
+  - repo: https://github.com/PyCQA/flake8
+    rev: 7.2.0
+    hooks:
+      - id: flake8
+        additional_dependencies:
+          - flake8-bugbear
+          - flake8-noqa
+        args:
+          - --max-line-length=120
+          - --max-complexity=18
+  - repo: https://github.com/psf/black
+    rev: 25.1.0
+    hooks:
+      - id: black
+        language_version: python3.12
+        args:
+          - --line-length=120
+  - repo: https://github.com/PyCQA/bandit
+    rev: "1.8.3"
+    hooks:
+      - id: bandit
+        args:
+          - -c
+          - bandit.yaml
+  - repo: https://github.com/PyCQA/isort
+    rev: "6.0.1"
+    hooks:
+      - id: isort
+  - repo: https://github.com/dosisod/refurb
+    rev: v2.0.0
+    hooks:
+      - id: refurb
+        additional_dependencies:
+          - boto3
+          - django-constance
+          - django-cors-headers
+          - django-environ
+          - django-extensions
+          - django-filter
+          - django-simple-history
+          - django-stubs[compatible-mypy]
+          - drf-spectacular
+          - drf-standardized-errors
+          - djangorestframework-stubs[compatible-mypy]
+          - zappa-django-utils
+  - repo: https://github.com/astral-sh/uv-pre-commit
+    rev: 0.6.12
+    hooks:
+      - id: uv-lock
+  - repo: https://github.com/astral-sh/ruff-pre-commit
+    rev: v0.11.4
+    hooks:
+      - id: ruff
+        args:
+          - --fix
+      - id: ruff-format
 # - repo: https://github.com/pre-commit/mirrors-mypy
 #   rev: 'v1.15.0'
 #   hooks:

app/cms/test/page_api_test.py

@@ -1,3 +1,5 @@
+import http
+
 import pytest
 from django.urls import reverse
 
@@ -8,13 +10,11 @@
 def test_list_view(api_client, create_page):
     url = reverse(PAGE_SITEMAP)
     response = api_client.get(url)
-    if response.status_code != 200:
-        raise Exception("cms Page list API raised error")
+    assert response.status_code == http.HTTPStatus.OK
 
 
 @pytest.mark.django_db
 def test_retrieve_view(api_client, create_page):
     url = reverse(PAGE_SITEMAP)
     response = api_client.get(url, kwargs={"pk": create_page.id})
-    if response.status_code != 200:
-        raise Exception("cms Page retrieve API raised error")
+    assert response.status_code == http.HTTPStatus.OK

app/cms/test/sitemap_api_test.py

@@ -1,3 +1,5 @@
+import http
+
 import pytest
 from django.urls import reverse
 
@@ -8,13 +10,13 @@
 def test_list_view(api_client, create_sitemap):
     url = reverse(CMS_SITEMAP)
     response = api_client.get(url)
-    if response.status_code != 200:
+    if response.status_code != http.HTTPStatus.OK:
         raise Exception("cms Sitemap list API raised error")
 
 
 @pytest.mark.django_db
 def test_retrieve_view(api_client, create_sitemap):
     url = reverse(CMS_SITEMAP)
     response = api_client.get(url, kwargs={"pk": create_sitemap.id})
-    if response.status_code != 200:
+    if response.status_code != http.HTTPStatus.OK:
         raise Exception("cms Sitemap retrieve API raised error")

app/cms/urls.py

@@ -16,9 +16,11 @@
 """
 
 from cms import views
-from django.urls import path
+from django.urls import include, path
+from rest_framework import routers
 
-urlpatterns = [
-    path("sitemap/", views.SitemapListRetrieveViewSet.as_view({"get": "list"}), name="cms-sitemap"),
-    path("page/", views.PageListRetrieveViewSet.as_view({"get": "list"}), name="cms-page"),
-]
+cms_router = routers.SimpleRouter()
+cms_router.register("sitemap/", views.SitemapListRetrieveViewSet, base_name="cms-sitemap")
+cms_router.register("page/", views.PageListRetrieveViewSet, base_name="cms-page")
+
+urlpatterns = [path("", include(cms_router.urls))]

app/core/urls.py

@@ -22,7 +22,8 @@
 from django.urls import include, path, re_path, resolvers
 from drf_spectacular.views import SpectacularAPIView, SpectacularSwaggerView
 
-v1_apis: list[resolvers.URLPattern | resolvers.URLResolver] = []  # type: ignore[assignment]
+# type: ignore[assignment]
+v1_apis: list[resolvers.URLPattern | resolvers.URLResolver] = [path("cms/", include("cms.urls"))]
 
 urlpatterns = [
     # Health Check
@@ -32,7 +33,6 @@
     path("admin/", admin.site.urls),
     # V1 API
     re_path("^v1/", include((v1_apis, "v1"), namespace="v1")),
-    path("cms/", include("cms.urls")),
 ] + static(settings.STATIC_URL, document_root=settings.STATIC_ROOT)
 
 if settings.DEBUG:

bandit.yaml

@@ -0,0 +1,4 @@
+assert_used:
+  skips:
+    - "test*.py"
+    - "*_test.py"

pyproject.toml

@@ -28,7 +28,6 @@ dependencies = [
     "zappa>=0.59.0",
     "zappa-django-utils>=0.4.1",
     "boto3 (>=1.37.37,<2.0.0)",
-    "pytest (>=8.3.5,<9.0.0)",
 ]
 
 [dependency-groups]
@@ -54,6 +53,7 @@ package = false
 default-groups = ["dev", "deployment"]
 
 [tool.poetry.group.dev.dependencies]
+pytest = ">=8.3.5,<9.0.0"
 pytest-django = "^4.11.1"
 
 [build-system]