Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 667: Clarify specification ambiguities and the expected impact #3845

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

PEP 667: Clarify specification ambiguities and the expected impact #3845

wants to merge 43 commits into from

Commits on Jun 19, 2024

  1. Add impact on exec() for PEP 667

    @gaogaotiantian
    gaogaotiantian committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    ab71e9a View commit details
    Browse the repository at this point in the history

  2. Fix lint

    @gaogaotiantian
    gaogaotiantian committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3d86025 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Carl Meyer <[email protected]>
    @gaogaotiantian @carljm
    gaogaotiantian and carljm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    8729874 View commit details
    Browse the repository at this point in the history

  2. Apply @carljm suggestions from review 

    Co-authored-by: Carl Meyer <[email protected]>
    @willingc @carljm
    willingc and carljm committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    e2f0b94 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2024

  1. Incorporate feedback and PyEval_GetLocals PR

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    98edffa View commit details
    Browse the repository at this point in the history

  2. Syntax fixes, PEP 558 comparison tweaks

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9a2a7d3 View commit details
    Browse the repository at this point in the history

  3. Move f_locals spec note to spec section

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    e67a37d View commit details
    Browse the repository at this point in the history

  4. Add missing space

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a2b6b33 View commit details
    Browse the repository at this point in the history

  5. Indent ctypes example

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6be7b28 View commit details
    Browse the repository at this point in the history

  6. Minor syntax and wording edits

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    f2423f0 View commit details
    Browse the repository at this point in the history

  7. Reword mention of "real" locals.

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    82f94fb View commit details
    Browse the repository at this point in the history

  8. PEP link fix, minor text edits

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    4a85e39 View commit details
    Browse the repository at this point in the history

  9. Add note about the extra PEP 558 C APIs being omitted

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6115fbd View commit details
    Browse the repository at this point in the history

  10. Another link syntax fix

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    669a0bc View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into pep-667-exec-impact

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    c68d02c View commit details
    Browse the repository at this point in the history

  12. Fix incorrect prefix in function name

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    9a966dd View commit details
    Browse the repository at this point in the history

  13. Improve locals() implementation note

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    98eddaf View commit details
    Browse the repository at this point in the history

  14. Clarify the note about deoptimization

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    a8a700d View commit details
    Browse the repository at this point in the history

  15. Be clear there is no is_function frame method

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    7808759 View commit details
    Browse the repository at this point in the history

  16. More syntax and wording tweaks

    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    6a89a65 View commit details
    Browse the repository at this point in the history

  17. Further updates 

    * try to highlight C code and interactive shell sessions properly
* make compatibility notes about redundant locals() copies
* show dict update in PyEval_GetLocals implementation sketch
    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    22494e4 View commit details
    Browse the repository at this point in the history

  18. No joy on mixed syntax highlighting 

    (and I'm not worried enough about it to add per-block adjustments)
    @ncoghlan
    ncoghlan committed Jun 25, 2024
    Configuration menu
    Copy the full SHA
    828daa2 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. Remove leftover comma 

    Co-authored-by: Carl Meyer <[email protected]>
    @ncoghlan @carljm
    ncoghlan and carljm committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    1bc2eaa View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Reword note about better optimization support

    @ncoghlan
    ncoghlan committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    a924f4b View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2024

  1. Merge branch 'main' into pep-667-exec-impact

    @ncoghlan
    ncoghlan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    c5d35e1 View commit details
    Browse the repository at this point in the history

  2. Address review comments from Barry & Tian

    @ncoghlan
    ncoghlan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    32fc5fb View commit details
    Browse the repository at this point in the history

  3. Syntax fix

    @ncoghlan
    ncoghlan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    6449585 View commit details
    Browse the repository at this point in the history

  4. Fix typo

    @ncoghlan
    ncoghlan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    a0881b1 View commit details
    Browse the repository at this point in the history

  5. f_locals is mutable, not read-only!

    @ncoghlan
    ncoghlan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    8dec696 View commit details
    Browse the repository at this point in the history

  6. Misc proofreading edits

    @ncoghlan
    ncoghlan committed Jul 4, 2024
    Configuration menu
    Copy the full SHA
    4151acb View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. Define exec/eval, fix proxy mutability 

    * exec/eval semantics should be clearly specified
* proxies do not fully implement MutableMapping
    @ncoghlan
    ncoghlan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    4871a39 View commit details
    Browse the repository at this point in the history

  2. Fix syntax, update implementation note

    @ncoghlan
    ncoghlan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ad391ea View commit details
    Browse the repository at this point in the history

  3. Another syntax fix

    @ncoghlan
    ncoghlan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    2269f65 View commit details
    Browse the repository at this point in the history

  4. Make snapshot code consistent

    @ncoghlan
    ncoghlan committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    1539941 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Use 3.13 signature for eval spec

    @ncoghlan
    ncoghlan committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0c5aea9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. Merge branch 'main' into pep-667-exec-impact

    @ncoghlan
    ncoghlan committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    a846667 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2024

  1. Delay PyEval_GetLocals hard deprecation to 3.14

    @ncoghlan
    ncoghlan committed Jul 27, 2024
    Configuration menu
    Copy the full SHA
    8abca04 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Petr Viktorin <[email protected]>
    @ncoghlan @encukou
    ncoghlan and encukou committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d3bff7b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into pep-667-exec-impact

    @ncoghlan
    ncoghlan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    40e59cb View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2024

  1. Move locals rationale details to PEP 558

    @ncoghlan
    ncoghlan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    1d4447d View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into pep-667-exec-impact

    @ncoghlan
    ncoghlan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    80e115b View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/main' into pep-667-exec-impact

    @ncoghlan
    ncoghlan committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c84fc0d View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2024

  1. Merge branch 'main' into pep-667-exec-impact

    @ncoghlan
    ncoghlan committed Aug 24, 2024
    Configuration menu
    Copy the full SHA
    b7b427f View commit details
    Browse the repository at this point in the history