Support @deprecated() on overloaded __get__ for generic descriptors
#18333
Conversation
This comment has been minimized.
This comment has been minimized.
Viicos
force-pushed
the
deprecated-generic-descriptors
branch
from
3e0684b to
8ca2a14
Compare
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
| @@ -7724,7 +7729,9 @@ def warn_deprecated_overload_item( | |||
| candidate := item.func.type, CallableType | |||
| ): | |||
| if selftype is not None: | |||
| candidate = bind_self(candidate, selftype) | |||
| candidate = bind_self( | |||
There was a problem hiding this comment.
I'm a bit surprised about this bind_self, actually. I cannot find where inferred_dunder_get_type gets passed to bind_self... I'm only looking at the code though. I'm certain it's used but... where?
There was a problem hiding this comment.
Hum, in analyze_descriptor_access, we pass inferred_dunder_get_type as target:
Lines 726 to 728 in 9ff9946
but not sure what you mean exactly
There was a problem hiding this comment.
Like I'd expect some sort of symmetry: we repeat the actions we did to get target on each overload member. But I can't find where we bind_self.
To be specific, in analyze_descriptor_access (or in a function it calls) I expect a bind_self call as dunder_get turns into inferred_dunder_get_type... but I can't find one. Is it just not necessary?
Fixes #18323.
Follow up on #18090.
Notes:
analyze_descriptor_access, there is a distinction betweentypanddescriptor_type:mypy/mypy/checkmember.py
Lines 687 to 688 in 9ff9946
map_instance_to_supertypereturnsdescriptor_typeunchanged. The reason I'm mentioning this is thatexpand_type_by_instanceusestypand notdescriptor_type. Inwarn_deprecated_overload_item, we have access todescriptor_type(passed asselftype):mypy/mypy/checkmember.py
Lines 726 to 728 in 9ff9946
expand_type_by_instance(candidate, selftype). Is this going to be an issue?selftypetoInstance. Is this going to be an issue?