gh-153569: simplify tokenizer and formatted-string state - #156484
Draft
pablogsal wants to merge 19 commits into
Draft
gh-153569: simplify tokenizer and formatted-string state#156484pablogsal wants to merge 19 commits into
pablogsal wants to merge 19 commits into
Conversation
| } | ||
|
|
||
| static int | ||
| fuzz_tokenizer(const char *data, size_t size) |
Member
There was a problem hiding this comment.
Please move it to python/library-fuzzers (yes, name is a little misleading). We aren't adding anything to _xxtestfuzz as we are planning to move it all to the repository.
Member
There was a problem hiding this comment.
@pablogsal a little ping FYI, since I see you're working on this.
Member
Author
|
Do not review until #156482 lands. |
pablogsal
force-pushed
the
gh-153569-tokenizer-validation-tools-clean
branch
from
August 28, 2026 18:40
5505010 to
68400fb
Compare
pablogsal
changed the title
pablogsal
force-pushed
the
gh-153569-tokenizer-validation-tools-clean
branch
from
August 28, 2026 19:35
68400fb to
7432a67
Compare
pablogsal
force-pushed
the
gh-153569-tokenizer-validation-tools-clean
branch
from
August 28, 2026 22:44
bb197e7 to
962c0c5
Compare
pablogsal
force-pushed
the
gh-153569-tokenizer-validation-tools-clean
branch
from
August 28, 2026 23:48
962c0c5 to
eae3e33
Compare
pablogsal
changed the title
pablogsal
changed the title
pablogsal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tokenizer kept several copies of the same positions and a fixed 150-entry mode array in every tokenizer. F- and t-string state now lives in a small stack containing only active formatted strings, and an empty stack means normal tokenization. Expressions and comments use source spans, bracket depth comes from the existing delimiter stack, and f-, t-, and raw strings share the same prefix and quote handling. This removes the dummy regular mode, duplicated depth fields, pointer repair code, and the extra stack that comments used to need. It also keeps expression text correct around comments, nested strings, and format specs.
Prepared input is normalized once and stored in one owned buffer. The reader owns buffer growth and streamed formatted strings stay in the active window, so the old cursor and buffer APIs, source aliases, per-line tables, reader counters, and parser-side tokenizer state can go away. This follows #156482 as the next part of #153569.