Skip to content

test_embed may fail if PYTHONSTARTUP set #157006

Description

@cmaloney

Bug report

Bug description:

The Visual Studio Code Python Extension (https://marketplace.visualstudio.com/items?itemName=ms-python.python) added what it calls "Shell Integration" recently. That adds aPYTHONSTARTUP environment variable to the environment variables of terminals it starts pointing to a file pythonrc.py. That changes the prompt the REPL prints and adds various hooks.

Changing what is printed breaks test_embed (./python -m test test_embed) which has some direct assertions on what is printed:

0:00:00 load avg: 0.20 mem: 41.2 MiB [1/1] test_embed
test test_embed failed -- Traceback (most recent call last):
  File "/home/$USER/projects/python/cpython/Lib/test/test_embed.py", line 621, in test_init_run_main_interactive_exitcode
    self.check_program_exitcode("test_init_run_main_interactive_exitcode",
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                input=code,
                                ^^^^^^^^^^^
                                check_stderr=False)
                                ^^^^^^^^^^^^^^^^^^^
  File "/home/$USER/projects/python/cpython/Lib/test/test_embed.py", line 602, in check_program_exitcode
    self.assertEqual(out.rstrip(), 'ok! Py_RunMain() returned 123')
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 'Ctrl click to launch VS Code Native REPL\nok! Py_RunMain() returned 123' != 'ok! Py_RunMain() returned 123'
- Ctrl click to launch VS Code Native REPL
  ok! Py_RunMain() returned 123


0:00:06 load avg: 0.51 mem: 42.1 MiB [1/1/1] test_embed failed (1 failure)

test_embed should clear / ignore the environment in this test (as it does many others).

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

testsTests in the Lib/test dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions