You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In 121ed71, mt_continue_should_break
was changed to be guarded by `Py_DEBUG`, but it's used in `compress_mt_continue_lock_held`
with just `assert`, so it needs to be available when `NDEBUG` is undefined
too.
`Py_DEBUG` implies `NDEBUG` is undefined, so we can check just that.
Fixes: 121ed71
…onGH-134769)
In 121ed71, mt_continue_should_break
was changed to be guarded by `Py_DEBUG`, but it's used in `compress_mt_continue_lock_held`
with just `assert`, so it needs to be available when `NDEBUG` is undefined
too.
`Py_DEBUG` implies `NDEBUG` is undefined, so we can check just that.
(cherry picked from commit 2f2bee2)
Co-authored-by: Sam James <[email protected]>
Fixes: 121ed71
…134769) (#134916)
gh-134768: Fix definition of `mt_continue_should_break()` (GH-134769)
In 121ed71, mt_continue_should_break
was changed to be guarded by `Py_DEBUG`, but it's used in `compress_mt_continue_lock_held`
with just `assert`, so it needs to be available when `NDEBUG` is undefined
too.
`Py_DEBUG` implies `NDEBUG` is undefined, so we can check just that.
(cherry picked from commit 2f2bee2)
Fixes: 121ed71
Co-authored-by: Sam James <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.
Bug report
Bug description:
The
3.14
branch andmain
both fail to build with--enable-assertions
:I'll send a patch now.
CPython versions tested on:
CPython main branch
Operating systems tested on:
Linux
Linked PRs
mt_continue_should_break()
#134769mt_continue_should_break()
(GH-134769) #134916The text was updated successfully, but these errors were encountered: