Skip to content

Commit ba53637

Browse files
committed
Revert py_version_short and py_version_nodot
1 parent 5c5ac7e commit ba53637

File tree

3 files changed

+9
-20
lines changed

3 files changed

+9
-20
lines changed

Lib/sysconfig/__init__.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,8 @@ def joinuser(*args):
173173
_SCHEME_KEYS = ('stdlib', 'platstdlib', 'purelib', 'platlib', 'include',
174174
'scripts', 'data')
175175

176+
_PY_VERSION_SHORT = f'{sys.version_info[0]}.{sys.version_info[1]}'
177+
_PY_VERSION_SHORT_NO_DOT = f'{sys.version_info[0]}{sys.version_info[1]}'
176178
_BASE_PREFIX = os.path.normpath(sys.base_prefix)
177179
_BASE_EXEC_PREFIX = os.path.normpath(sys.base_exec_prefix)
178180
# Mutex guarding initialization of _CONFIG_VARS.
@@ -321,8 +323,7 @@ def get_makefile_filename():
321323
return os.path.join(_PROJECT_BASE, "Makefile")
322324

323325
if hasattr(sys, 'abiflags'):
324-
py_version_short = f'{sys.version_info[0]}.{sys.version_info[1]}'
325-
config_dir_name = f'config-{py_version_short}{sys.abiflags}'
326+
config_dir_name = f'config-{_PY_VERSION_SHORT}{sys.abiflags}'
326327
else:
327328
config_dir_name = 'config'
328329

@@ -405,7 +406,7 @@ def _init_non_posix(vars):
405406
vars['LIBRARY'] = os.path.basename(_safe_realpath(dllhandle))
406407
vars['LDLIBRARY'] = vars['LIBRARY']
407408
vars['EXE'] = '.exe'
408-
vars['VERSION'] = vars['py_version_nodot']
409+
vars['VERSION'] = _PY_VERSION_SHORT_NO_DOT
409410
vars['BINDIR'] = os.path.dirname(_safe_realpath(sys.executable))
410411
# No standard path exists on Windows for this, but we'll check
411412
# whether someone is imitating a POSIX-like layout
@@ -529,6 +530,8 @@ def _init_config_vars():
529530
# Distutils.
530531
_CONFIG_VARS['prefix'] = prefix
531532
_CONFIG_VARS['exec_prefix'] = exec_prefix
533+
_CONFIG_VARS['py_version_short'] = _PY_VERSION_SHORT
534+
_CONFIG_VARS['py_version_nodot'] = _PY_VERSION_SHORT_NO_DOT
532535
_CONFIG_VARS['installed_base'] = base_prefix
533536
_CONFIG_VARS['base'] = prefix
534537
_CONFIG_VARS['installed_platbase'] = base_exec_prefix
@@ -735,11 +738,11 @@ def get_platform():
735738

736739

737740
def get_python_version():
738-
return get_config_var('py_version_short')
741+
return _PY_VERSION_SHORT
739742

740743

741744
def _get_python_version_abi():
742-
return get_config_var('py_version_short') + get_config_var('abi_thread')
745+
return _PY_VERSION_SHORT + get_config_var("abi_thread")
743746

744747

745748
def expand_makefile_vars(s, vars):

Lib/test/test_sysconfig.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ def test_py_version(self):
755755
self.assertEqual(config_vars['py_version_short'],
756756
f'{ver.major}.{ver.minor}')
757757
self.assertEqual(sysconfig.get_python_version(),
758-
config_vars['py_version_short'])
758+
f'{ver.major}.{ver.minor}')
759759

760760
# Test py_version_nodot
761761
self.assertIsInstance(config_vars['py_version_nodot'], str)

Modules/_sysconfig.c

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,6 @@ module _sysconfig
1717

1818
#include "clinic/_sysconfig.c.h"
1919

20-
21-
#define py_version_short() \
22-
(Py_STRINGIFY(PY_MAJOR_VERSION) "." Py_STRINGIFY(PY_MINOR_VERSION))
23-
#define py_version_nodot() \
24-
(Py_STRINGIFY(PY_MAJOR_VERSION) Py_STRINGIFY(PY_MINOR_VERSION))
25-
26-
2720
static int
2821
add_string_value(PyObject *dict, const char *key, const char *str_value)
2922
{
@@ -36,7 +29,6 @@ add_string_value(PyObject *dict, const char *key, const char *str_value)
3629
return err;
3730
}
3831

39-
4032
/*[clinic input]
4133
@permit_long_summary
4234
_sysconfig.config_vars
@@ -57,12 +49,6 @@ _sysconfig_config_vars_impl(PyObject *module)
5749
if (add_string_value(config, "py_version", PY_VERSION) < 0) {
5850
goto error;
5951
}
60-
if (add_string_value(config, "py_version_short", py_version_short()) < 0) {
61-
goto error;
62-
}
63-
if (add_string_value(config, "py_version_nodot", py_version_nodot()) < 0) {
64-
goto error;
65-
}
6652

6753
#ifdef MS_WINDOWS
6854
if (add_string_value(config, "EXT_SUFFIX", PYD_TAGGED_SUFFIX) < 0) {

0 commit comments

Comments
 (0)