Skip to content

Commit 5160ed0

Browse files
committed
Respond to comments.
1 parent d5092ba commit 5160ed0

4 files changed

Lines changed: 37 additions & 34 deletions

File tree

Lib/idlelib/idle_test/template.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@ def tearDownClass(cls):
2121
cls.root.destroy()
2222
del cls.root
2323

24+
@unittest.skip('Dummy test')
2425
def test_init(self):
25-
self.assertTrue(self)
26+
self.assertTrue(True)
2627

2728

2829
if __name__ == '__main__':

Lib/idlelib/idle_test/test_autocomplete.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,8 @@ def test_fetch_completions(self):
238238
# Test attributes
239239
s, b = acp.fetch_completions('', ac.ATTRS)
240240
self.assertLess(len(small), len(large))
241-
self.assertFalse(any(x.startswith('_') for x in s))
242-
self.assertTrue(any(x.startswith('_') for x in b))
241+
self.assertFalse(any(x[0] == '_' for x in s))
242+
self.assertTrue(any(x[0] == '_' for x in b))
243243

244244
# Test smalll should respect to __all__.
245245
with patch.dict('__main__.__dict__', {'__all__': ['a', 'b']}):

Lib/idlelib/idle_test/test_configdialog.py

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,14 @@ def tearDownModule():
5050
root = dialog = None
5151

5252

53-
##class ConfigDialogTest(unittest.TestCase):
54-
##
55-
## def test_deactivate_current_config(self):
56-
## pass
57-
##
58-
## def activate_config_changes(self):
59-
## pass
53+
@unittest.skip('Empty tests')
54+
class ConfigDialogTest(unittest.TestCase):
55+
56+
def test_deactivate_current_config(self):
57+
pass
58+
59+
def activate_config_changes(self):
60+
pass
6061

6162

6263
class ButtonTest(unittest.TestCase):

Lib/idlelib/idle_test/test_editor.py

Lines changed: 25 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -211,30 +211,31 @@ def test_searcher(self):
211211
self.assertEqual(actual_pair, expected_pair)
212212

213213

214-
##class RMenuTest(unittest.TestCase):
215-
##
216-
## @classmethod
217-
## def setUpClass(cls):
218-
## requires('gui')
219-
## cls.root = Tk()
220-
## cls.root.withdraw()
221-
## cls.window = Editor(root=cls.root)
222-
##
223-
## @classmethod
224-
## def tearDownClass(cls):
225-
## cls.window._close()
226-
## del cls.window
227-
## cls.root.update_idletasks()
228-
## for id in cls.root.after_info():
229-
## cls.root.after_cancel(id)
230-
## cls.root.destroy()
231-
## del cls.root
232-
##
233-
## class DummyRMenu:
234-
## def tk_popup(x, y): pass
235-
##
236-
## def test_rclick(self):
237-
## pass # Comment out because cannot fail; gh-155648.
214+
@unittest.skip('Empty test')
215+
class RMenuTest(unittest.TestCase):
216+
217+
@classmethod
218+
def setUpClass(cls):
219+
requires('gui')
220+
cls.root = Tk()
221+
cls.root.withdraw()
222+
cls.window = Editor(root=cls.root)
223+
224+
@classmethod
225+
def tearDownClass(cls):
226+
cls.window._close()
227+
del cls.window
228+
cls.root.update_idletasks()
229+
for id in cls.root.after_info():
230+
cls.root.after_cancel(id)
231+
cls.root.destroy()
232+
del cls.root
233+
234+
class DummyRMenu:
235+
def tk_popup(x, y): pass
236+
237+
def test_rclick(self):
238+
pass
238239

239240

240241
if __name__ == '__main__':

0 commit comments

Comments
 (0)