Add lint check for v.get(...) and simlar errors.

Author: nascheme

Tools/configure/transpiler/lint_transpilable.py

@@ -174,6 +174,17 @@
     }
 )
 
+# Allowed Vars (v) method calls.  The Vars object uses __getattr__ to
+# return env/empty-string for unknown attributes, so calling anything
+# other than these real methods (e.g. v.get()) silently returns a string
+# and then fails at runtime with "TypeError: 'str' object is not callable".
+ALLOWED_VARS_METHODS = frozenset(
+    {
+        "export",
+        "is_set",
+    }
+)
+
 # Allowed string methods that have shell equivalents.
 ALLOWED_STR_METHODS = frozenset(
     {
@@ -810,11 +821,18 @@ def _check_call(self, node):
                     self._check_expr(kw.value)
                 return
 
-        # v.export(...) and other Vars methods — allowed
+        # v.export(...) / v.is_set(...) — allowed Vars methods
         if isinstance(func, ast.Attribute) and isinstance(
             func.value, ast.Name
         ):
             if func.value.id == "v":
+                if func.attr not in ALLOWED_VARS_METHODS:
+                    self._warn(
+                        node,
+                        f"v.{func.attr}(): not in allowed Vars methods"
+                        f" ({', '.join(sorted(ALLOWED_VARS_METHODS))})"
+                        " — use v.ATTR for attribute access instead",
+                    )
                 for arg in node.args:
                     self._check_expr(arg)
                 for kw in node.keywords:

Tools/configure/transpiler/transpile.py

@@ -14,6 +14,7 @@
 from . import py_to_pysh
 from .pysh_ast import ModuleInfo, OptionInfo
 from .py_to_pysh import parse_option_decl
+from .lint_transpilable import lint_file
 
 from . import pysh_to_awk
 from . import awk_emit
@@ -41,6 +42,20 @@
 
 
 def transpile_configure(script_dir: str) -> str:
+    # Lint conf_*.py files before transpiling
+    import glob as _glob
+
+    conf_files = sorted(_glob.glob(os.path.join(script_dir, "conf_*.py")))
+    all_violations = []
+    for filepath in conf_files:
+        result = lint_file(filepath)
+        all_violations.extend(result.violations)
+    if all_violations:
+        msgs = "\n".join(f"  {v}" for v in all_violations)
+        raise ValueError(
+            f"lint check failed with {len(all_violations)} violation(s):\n{msgs}"
+        )
+
     # Parse Python source, produce Python AST, transform to pysh AST
     program = py_to_pysh.parse_program(script_dir)
     # Transform pysh AST → AWK AST