Skip to content

Commit 283b050

Browse files
authored
gh-127146: Emscripten: Fix test_open_undecodable_uri by setting -sTEXTDECODER=2 (#136624)
Removes the JS text decoder fallback and gets rid of the bugs due to the differences in behavior on invalid utf8 strings. See emscripten-core/emscripten#24690.
1 parent da699ed commit 283b050

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

configure

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

configure.ac

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2338,6 +2338,8 @@ AS_CASE([$ac_sys_system],
23382338
AS_VAR_APPEND([LINKFORSHARED], [" -sEXPORTED_RUNTIME_METHODS=FS,callMain,ENV"])
23392339
AS_VAR_APPEND([LINKFORSHARED], [" -sEXPORTED_FUNCTIONS=_main,_Py_Version,__PyRuntime,__PyEM_EMSCRIPTEN_COUNT_ARGS_OFFSET,_PyGILState_GetThisThreadState,__Py_DumpTraceback"])
23402340
AS_VAR_APPEND([LINKFORSHARED], [" -sSTACK_SIZE=5MB"])
2341+
dnl Avoid bugs in JS fallback string decoding path
2342+
AS_VAR_APPEND([LINKFORSHARED], [" -sTEXTDECODER=2"])
23412343
23422344
AS_VAR_IF([enable_wasm_dynamic_linking], [yes], [
23432345
AS_VAR_APPEND([LINKFORSHARED], [" -sMAIN_MODULE"])

0 commit comments

Comments
 (0)