Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lock recipe (at least) makes invalid assumption on Zookeeper sequence numbers #606

Open
ceache opened this issue Apr 25, 2020 · 0 comments
Open

Lock recipe (at least) makes invalid assumption on Zookeeper sequence numbers #606

ceache opened this issue Apr 25, 2020 · 0 comments
Assignees
@ceache
Labels
Bug Documentation NeedsTests Recipe

Comments

@ceache
Copy link
Contributor

ceache commented Apr 25, 2020

kazoo/kazoo/recipe/lock.py

Line 286 in b20c929

# sort correctly anyway).

This assumption badly broken. Sequence numbers are signed 32bit wrapping numbers.

https://zookeeper.apache.org/doc/r3.6.0/zookeeperProgrammers.html#Sequence+Nodes+--+Unique+Naming

The proper way to handle them is to use SNA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceache ceache

Labels
Bug Documentation NeedsTests Recipe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ceache