add initial tox.ini #3196
Open
add initial tox.ini #3196
+193
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ugh, native toml not supporting https://tox.wiki/en/latest/config.html#conditional-settings makes it a non-trivial conversion. I think the way to get around that is with more explicit environments + https://tox.wiki/en/latest/config.html#string-substitution-references; but... that's for another day/person |
|
If you review I propose delaying further CI/ |
CoolCat467
reviewed
Feb 14, 2025
Comment on lines
+77
to
+79
| mypy --platform linux | ||
| mypy --platform darwin | ||
| mypy --platform win32 |
There was a problem hiding this comment.
Shouldn't this use mypy_annotate?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out on a tox.ini because it's handy to have; it's not complete enough to close #3170, but it should be sufficient for #2699 once the CI is updated to use it.
noxfor that not to be a nightmare.tox.iniI didn't realize this until most of the file was written.ci.ymlto actually use this. We'd probably want https://github.com/tox-dev/tox-gh or https://github.com/ymyzk/tox-gh-actions to do that properlyeverybody's very welcome to push commits to this PR, but I don't think we should block merging it until the tox/nox config is perfect (leaving that for followup PRs) Cause I Wanna Use It ™️