Cleanup, linting, typing (#9839)

Author: dimbleby

.pre-commit-config.yaml

@@ -27,7 +27,7 @@ repos:
       - id: validate_manifest
 
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.5.4
+    rev: v0.7.3
     hooks:
       - id: ruff
       - id: ruff-format

poetry.lock

@@ -98,8 +98,6 @@ extend-exclude = [
     # External to the project's coding standards
     "tests/fixtures/git/*",
     "tests/fixtures/project_with_setup*/*",
-    "tests/masonry/builders/fixtures/pep_561_stub_only*/*",
-    "tests/utils/fixtures/setups/*",
 ]
 fix = true
 line-length = 88

pyproject.toml

@@ -16,7 +16,6 @@
 from cleo.events.event_dispatcher import EventDispatcher
 from cleo.exceptions import CleoError
 from cleo.formatters.style import Style
-from cleo.io.null_io import NullIO
 
 from poetry.__version__ import __version__
 from poetry.console.command_loader import CommandLoader
@@ -322,13 +321,10 @@ def configure_installer_for_command(command: InstallerCommand, io: IO) -> None:
         )
         command.set_installer(installer)
 
-    def _load_plugins(self, io: IO | None = None) -> None:
+    def _load_plugins(self, io: IO) -> None:
         if self._plugins_loaded:
             return
 
-        if io is None:
-            io = NullIO()
-
         self._disable_plugins = io.input.has_parameter_option("--no-plugins")
 
         if not self._disable_plugins:

src/poetry/console/application.py

@@ -10,11 +10,10 @@
 from bisect import bisect_right
 from contextlib import contextmanager
 from tempfile import NamedTemporaryFile
+from typing import IO
 from typing import TYPE_CHECKING
 from typing import Any
-from typing import BinaryIO
 from typing import ClassVar
-from typing import cast
 from urllib.parse import urlparse
 from zipfile import BadZipFile
 from zipfile import ZipFile
@@ -168,14 +167,14 @@ def minimal_intervals_covering(
         yield from self._merge(start, end, left, right)
 
 
-class ReadOnlyIOWrapper(BinaryIO):
-    """Implement read-side ``BinaryIO`` methods wrapping an inner ``BinaryIO``.
+class ReadOnlyIOWrapper(IO[bytes]):
+    """Implement read-side ``IO[bytes]`` methods wrapping an inner ``IO[bytes]``.
 
     This wrapper is useful because Python currently does not distinguish read-only
     streams at the type level.
     """
 
-    def __init__(self, inner: BinaryIO) -> None:
+    def __init__(self, inner: IO[bytes]) -> None:
         self._file = inner
 
     def __enter__(self) -> Self:
@@ -296,7 +295,8 @@ def __init__(
         session: Session | Authenticator,
         delete_backing_file: bool = True,
     ) -> None:
-        super().__init__(cast(BinaryIO, NamedTemporaryFile(delete=delete_backing_file)))
+        inner = NamedTemporaryFile(delete=delete_backing_file)  # noqa: SIM115
+        super().__init__(inner)
 
         self._merge_intervals: MergeIntervals | None = None
         self._length: int | None = None

src/poetry/inspection/lazy_wheel.py

@@ -397,7 +397,7 @@ def extractall(source: Path, dest: Path, zip: bool) -> None:
     else:
         # These versions of python shipped with a broken tarfile data_filter, per
         # https://github.com/python/cpython/issues/107845.
-        broken_tarfile_filter = {(3, 8, 17), (3, 9, 17), (3, 10, 12), (3, 11, 4)}
+        broken_tarfile_filter = {(3, 9, 17), (3, 10, 12), (3, 11, 4)}
         with tarfile.open(source) as archive:
             if (
                 hasattr(tarfile, "data_filter")

src/poetry/utils/helpers.py

@@ -40,7 +40,7 @@ def run(*args: Any, **kwargs: Any) -> None:
         git_command = find_git_command()
         env = os.environ.copy()
         env["GIT_TERMINAL_PROMPT"] = "0"
-        subprocess.check_call(  # type: ignore[call-arg]
+        subprocess.check_call(
             git_command + list(args),
             stderr=subprocess.DEVNULL,
             stdout=subprocess.DEVNULL,

src/poetry/vcs/git/system.py

@@ -97,7 +97,8 @@ def poetry(
 @pytest.fixture
 def app(poetry: Poetry) -> PoetryTestApplication:
     app_ = PoetryTestApplication(poetry)
-    app_._load_plugins()
+    io = NullIO()
+    app_._load_plugins(io)
     return app_
 
 

tests/console/conftest.py

@@ -310,11 +310,11 @@ def test_system_git_fallback_on_http_401(
 
 GIT_USERNAME = os.environ.get("POETRY_TEST_INTEGRATION_GIT_USERNAME")
 GIT_PASSWORD = os.environ.get("POETRY_TEST_INTEGRATION_GIT_PASSWORD")
-HTTP_AUTH_CREDENTIALS_AVAILABLE = not (GIT_USERNAME and GIT_PASSWORD)
+HTTP_AUTH_CREDENTIALS_UNAVAILABLE = not (GIT_USERNAME and GIT_PASSWORD)
 
 
 @pytest.mark.skipif(
-    HTTP_AUTH_CREDENTIALS_AVAILABLE,
+    HTTP_AUTH_CREDENTIALS_UNAVAILABLE,
     reason="HTTP authentication credentials not available",
 )
 def test_configured_repository_http_auth(