Add formula.element to accumulate across isotopes and ions #66
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing formula.atoms attribute keeps the isotopes + charges separate when accumulating the components.
This proposal uses formula.elements to accumulate across isotopes and charges. It also adds formula.elements_hill to return a structure in hill notation order.
Having written this, several questions arise:
I made the underlying count_elements() function public and gave it a by_isotopes flag.
I'll await comments from those who can use this functionality before merging.
Refs #14